-
Notifications
You must be signed in to change notification settings - Fork 3.9k
GH-48095: [Python][Docs] Add missing {pyarrow,compute} functions to API docs #48117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GH-48095: [Python][Docs] Add missing {pyarrow,compute} functions to API docs #48117
Conversation
|
|
|
I haven’t included |
|
Thanks @tadeja!
I think it should have been here: arrow/docs/source/python/api/arrays.rst Lines 24 to 33 in 0c20874
Which also made me realize that some others in that module are missing too: |
|
@dangotbanned that should be correct. I would also add |
fe36e88 to
cb4cb70
Compare
AlenkaF
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Co-authored-by: Alenka Frim <[email protected]>
|
Thanks @AlenkaF, @dangotbanned. |
|
|
|
Revision: 56043a1 Submitted crossbow builds: ursacomputing/crossbow @ actions-0ec9937bf0
|
|
@github-actions crossbow submit preview-docs |
|
Revision: bd372aa Submitted crossbow builds: ursacomputing/crossbow @ actions-ff8cf53890
|
AlenkaF
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!!
|
@AlenkaF A side note regarding added
|
Oh, yeah. I seem to remember we have talked about this with Joris in the past. It is a bit confusing for the user to have
I think #29556 can be closed and we might want to wait for #29839 to be solved before adding |
|
@AlenkaF, thank you. So I've removed |
|
Not sure why the linter job is failing on an unrelated code. |
|
There is already an open PR for the linter error here: #48173. |
|
I'll try to look at this later today |
raulcd
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've gone over the rendered docs and this looks great to me! Thank you very much @tadeja for the work here!
|
|
Issue #48095 and #45322
Rationale for this change
Missing API doc entries.
What changes are included in this PR?
I've added strings for functions and options to the API doc page.
Are these changes tested?
I've built docs locally.
Are there any user-facing changes?
Docs only.
{pyarrow,compute}functions to API docs #48095