Skip to content

GH-47716: [C++][FlightRPC] ODBC bind column implementation#48042

Merged
lidavidm merged 1 commit into
apache:mainfrom
Bit-Quill:gh-47716-sql-bind-col
Dec 9, 2025
Merged

GH-47716: [C++][FlightRPC] ODBC bind column implementation#48042
lidavidm merged 1 commit into
apache:mainfrom
Bit-Quill:gh-47716-sql-bind-col

Conversation

@alinaliBQ

@alinaliBQ alinaliBQ commented Nov 4, 2025

Copy link
Copy Markdown
Collaborator

Rationale for this change

Add support for column binding in ODBC.

What changes are included in this PR?

  • Implement SQLBindCol & tests

Are these changes tested?

Tested on local MSVC

Are there any user-facing changes?

N/A

@github-actions

github-actions Bot commented Nov 4, 2025

Copy link
Copy Markdown

⚠️ GitHub issue #47716 has been automatically assigned in GitHub to PR creator.

@alinaliBQ alinaliBQ force-pushed the gh-47716-sql-bind-col branch from 8ff2cca to 87e634a Compare November 10, 2025 22:34
@alinaliBQ alinaliBQ changed the title GH-47716: [C++][FlightRPC] WIP: ODBC bind column implementation GH-47716: [C++][FlightRPC] ODBC bind column implementation Nov 10, 2025
@alinaliBQ

Copy link
Copy Markdown
Collaborator Author

@lidavidm this draft PR is ready for review! Please have a look

@alinaliBQ alinaliBQ force-pushed the gh-47716-sql-bind-col branch 2 times, most recently from 077666f to e1a223f Compare December 4, 2025 00:07
Use `ASSERT` instead of `EXPECT` gtest checks

Co-Authored-By: alinalibq <alina.li@improving.com>
@alinaliBQ alinaliBQ force-pushed the gh-47716-sql-bind-col branch from e1a223f to a2201f0 Compare December 8, 2025 19:37
@alinaliBQ alinaliBQ marked this pull request as ready for review December 8, 2025 19:38
@alinaliBQ alinaliBQ requested a review from lidavidm as a code owner December 8, 2025 19:38
@lidavidm lidavidm merged commit e5f05c7 into apache:main Dec 9, 2025
46 checks passed
@lidavidm lidavidm removed the awaiting review Awaiting review label Dec 9, 2025
@github-actions github-actions Bot added the awaiting merge Awaiting merge label Dec 9, 2025
@conbench-apache-arrow

Copy link
Copy Markdown

After merging your PR, Conbench analyzed the 3 benchmarking runs that have been run so far on merge-commit e5f05c7.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details. It also includes information about 1 possible false positive for unstable benchmarks that are known to sometimes produce them.

Mottl pushed a commit to Mottl/arrow that referenced this pull request May 26, 2026
…che#48042)

### Rationale for this change
Add support for column binding in ODBC. 

### What changes are included in this PR?
- Implement SQLBindCol & tests
### Are these changes tested?
Tested on local MSVC

### Are there any user-facing changes?

N/A

* GitHub Issue: apache#47716

Authored-by: Alina (Xi) Li <alina.li@improving.com>
Signed-off-by: David Li <li.davidm96@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants