GH-48025: [C++][GLib] Replace instances where build path is being added to built artifacts#48026
Merged
Conversation
|
|
Member
Author
|
As far as I understand failures are unrelated. Examples:
I am unsure on what is the problem on C GLib & Ruby / AMD64 Ubuntu 22.04 GLib & Ruby but does not seem related: |
Member
|
The "undefined method" error will be fixed soon in upstream: test-unit/test-unit#329 |
Co-authored-by: Sutou Kouhei <kou@cozmixng.org>
|
After merging your PR, Conbench analyzed the 0 benchmarking runs that have been run so far on merge-commit 534ef71. None of the specified runs were found on the Conbench server. The full Conbench report has more details. |
Mottl
pushed a commit
to Mottl/arrow
that referenced
this pull request
May 26, 2026
…ng added to built artifacts (apache#48026) ### Rationale for this change There are several places where we are adding the build path on our built artifacts. We should avoid that in order to improve reproducibility of our builds. ### What changes are included in this PR? General build system hygiene improvement redacting absolute paths from the compiler flags to improve build reproducibility and caching efficiency. Update for mkenums from full `@ filename@` to `@ basename@` as seen on their official documentation: > The base name of the input file currently being processed (e.g. foo.h). Typically you want to use `@ basename@` in place of `@ filename@` in your templates, to improve the reproducibility of the build. (Since: 2.22) ### Are these changes tested? Validated locally that reprotest doesn't fail on `enums` anymore. CI and tests have run. ### Are there any user-facing changes? No * GitHub Issue: apache#48025 Lead-authored-by: Raúl Cumplido <raulcumplido@gmail.com> Co-authored-by: Sutou Kouhei <kou@cozmixng.org> Signed-off-by: Raúl Cumplido <raulcumplido@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
There are several places where we are adding the build path on our built artifacts. We should avoid that in order to improve reproducibility of our builds.
What changes are included in this PR?
General build system hygiene improvement redacting absolute paths from the compiler flags to improve build reproducibility and caching efficiency.
Update for mkenums from full
@filename@to@basename@as seen on their official documentation:Are these changes tested?
Validated locally that reprotest doesn't fail on
enumsanymore.CI and tests have run.
Are there any user-facing changes?
No