GH-47710: [C++][FlightRPC] Statement attribute Support in ODBC by alinaliBQ · Pull Request #47773 · apache/arrow

alinaliBQ · 2025-10-09T22:53:10Z

Rationale for this change

Support for getting and setting statement attributes in ODBC is added.

What changes are included in this PR?

Implementation of SQLGetStmtAttr and SQLSetStmtAttr to get and set statement attributes.
Tests

Are these changes tested?

Tested on local MSVC

Are there any user-facing changes?

No

GitHub Issue: [C++][FlightRPC][ODBC] SQLGetStmtAttr & SQLSetStmtAttr implementation #47710

alinaliBQ · 2025-10-09T22:53:22Z

@lidavidm @kou Please review this draft ODBC API PR, thanks. The testing folder structure will be in a separate PR

github-actions · 2025-10-09T22:53:35Z

⚠️ GitHub issue #47710 has been automatically assigned in GitHub to PR creator.

lidavidm

Same general comments as the other PRs.

alinaliBQ · 2025-10-21T22:31:40Z

we worked on:

replace EXPECT_ with ASSERT_ where applicable
use platform.h
still in-progress on subclassing test fixture and moving connect/disconnect to setup/teardown

alinaliBQ · 2025-10-22T23:07:54Z

Rebased on top of master branch. Wrapped up subclassing test fixture and moving connect/disconnect to setup/teardown.

lidavidm · 2025-10-23T07:48:27Z

+namespace {
+// Helper Functions
+
+// Validate SQLULEN return value
+void ValidateGetStmtAttr(SQLHSTMT statement, SQLINTEGER attribute,
+                         SQLULEN expected_value) {
+  SQLULEN value = 0;
+  SQLINTEGER string_length = 0;
+
+  ASSERT_EQ(SQL_SUCCESS,
+            SQLGetStmtAttr(statement, attribute, &value, sizeof(value), &string_length));
+
+  EXPECT_EQ(expected_value, value);
+}


Instead of having variants for each type of comparison (equal, greater than, etc.) wouldn't it be better to just have a getter for each type, and keep the assertion in the tests themselves? (It could throw on failure, for instance, to keep the signature simple.)

Yea that makes sense. I added getters, please let me know what you think

alinaliBQ

worked on comment

alinaliBQ · 2025-10-28T21:55:59Z

+namespace {
+// Helper Functions
+
+// Validate SQLULEN return value
+void ValidateGetStmtAttr(SQLHSTMT statement, SQLINTEGER attribute,
+                         SQLULEN expected_value) {
+  SQLULEN value = 0;
+  SQLINTEGER string_length = 0;
+
+  ASSERT_EQ(SQL_SUCCESS,
+            SQLGetStmtAttr(statement, attribute, &value, sizeof(value), &string_length));
+
+  EXPECT_EQ(expected_value, value);
+}


Yea that makes sense. I added getters, please let me know what you think

Co-Authored-By: rscales <robscales@icloud.com>

Add tests for setting and getting statement attributes Co-Authored-By: rscales <robscales@icloud.com>

- use `platform.h` - move `connect/disconnect` to `setup/teardown` - in-progress on subclassing test fixture Co-authored-by: justing-bq <justin.gossett@improving.com> Co-authored-by: alinalibq <alina.li@improving.com>

- remove `using List = std::list<T>;`

conbench-apache-arrow · 2025-11-28T11:08:51Z

After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit 430d4b1.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details. It also includes information about 3 possible false positives for unstable benchmarks that are known to sometimes produce them.

…pache#47773) ### Rationale for this change Support for getting and setting statement attributes in ODBC is added. ### What changes are included in this PR? - Implementation of `SQLGetStmtAttr` and `SQLSetStmtAttr` to get and set statement attributes. - Tests ### Are these changes tested? Tested on local MSVC ### Are there any user-facing changes? No * GitHub Issue: apache#47710 Lead-authored-by: Alina (Xi) Li <alina.li@improving.com> Co-authored-by: alinalibq <alina.li@improving.com> Co-authored-by: justing-bq <justin.gossett@improving.com> Signed-off-by: David Li <li.davidm96@gmail.com>

github-actions Bot added Component: C++ Component: FlightRPC awaiting review Awaiting review labels Oct 9, 2025

lidavidm reviewed Oct 10, 2025

View reviewed changes

github-actions Bot added awaiting changes Awaiting changes and removed awaiting review Awaiting review labels Oct 10, 2025

alinaliBQ mentioned this pull request Oct 10, 2025

GH-46734: [C++] Arrow Flight SQL ODBC layer #46099

Open

alinaliBQ force-pushed the gh-47710-sql-stmt-attr branch from 42f4f14 to 1e025c7 Compare October 21, 2025 22:30

github-actions Bot added awaiting change review Awaiting change review and removed awaiting changes Awaiting changes labels Oct 21, 2025

alinaliBQ force-pushed the gh-47710-sql-stmt-attr branch from 1e025c7 to be51a05 Compare October 22, 2025 23:07

alinaliBQ requested a review from lidavidm October 22, 2025 23:08

lidavidm reviewed Oct 23, 2025

View reviewed changes

github-actions Bot added awaiting changes Awaiting changes and removed awaiting change review Awaiting change review labels Oct 23, 2025

alinaliBQ force-pushed the gh-47710-sql-stmt-attr branch from be51a05 to aebac29 Compare October 28, 2025 21:55

github-actions Bot added awaiting change review Awaiting change review and removed awaiting changes Awaiting changes labels Oct 28, 2025

alinaliBQ commented Oct 28, 2025

View reviewed changes

alinaliBQ requested a review from lidavidm October 28, 2025 21:56

lidavidm approved these changes Oct 31, 2025

View reviewed changes

github-actions Bot added awaiting merge Awaiting merge and removed awaiting change review Awaiting change review labels Oct 31, 2025

alinaliBQ mentioned this pull request Oct 31, 2025

GH-47709: [C++][FlightRPC] Return ODBC and data source information #47762

Merged

alinaliBQ force-pushed the gh-47710-sql-stmt-attr branch from 0675c21 to bafe934 Compare November 14, 2025 23:06

alinaliBQ marked this pull request as ready for review November 14, 2025 23:06

alinaliBQ and others added 7 commits November 20, 2025 13:47

Extract SQLGetStmtAttr and SQLSetStmtAttr

88b7597

Co-Authored-By: rscales <robscales@icloud.com>

Create statement_attr_test.cc

48a2cf3

Add tests for setting and getting statement attributes Co-Authored-By: rscales <robscales@icloud.com>

Work on code review comments

019c947

- use `platform.h` - move `connect/disconnect` to `setup/teardown` - in-progress on subclassing test fixture Co-authored-by: justing-bq <justin.gossett@improving.com> Co-authored-by: alinalibq <alina.li@improving.com>

Rebase on top of master

1f65876

- remove `using List = std::list<T>;`

Develop getter for tests

3dfe852

Swap EQ statements to have value as second input

1e5ee78

Fix SQLStmtAttr tests

501eab7

alinaliBQ force-pushed the gh-47710-sql-stmt-attr branch from bafe934 to 501eab7 Compare November 20, 2025 22:04

lidavidm approved these changes Nov 21, 2025

View reviewed changes

lidavidm merged commit 430d4b1 into apache:main Nov 28, 2025
43 of 46 checks passed

lidavidm removed the awaiting merge Awaiting merge label Nov 28, 2025

lidavidm mentioned this pull request Nov 28, 2025

[C++][FlightRPC][ODBC] SQLGetStmtAttr & SQLSetStmtAttr implementation #47710

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

GH-47710: [C++][FlightRPC] Statement attribute Support in ODBC#47773

GH-47710: [C++][FlightRPC] Statement attribute Support in ODBC#47773
lidavidm merged 7 commits into
apache:mainfrom
Bit-Quill:gh-47710-sql-stmt-attr

alinaliBQ commented Oct 9, 2025 •

edited

Loading

Uh oh!

alinaliBQ commented Oct 9, 2025

Uh oh!

github-actions Bot commented Oct 9, 2025

Uh oh!

lidavidm left a comment

Uh oh!

alinaliBQ commented Oct 21, 2025

Uh oh!

alinaliBQ commented Oct 22, 2025

Uh oh!

lidavidm Oct 23, 2025

Uh oh!

alinaliBQ Oct 28, 2025

Uh oh!

alinaliBQ left a comment

Uh oh!

alinaliBQ Oct 28, 2025

Uh oh!

Uh oh!

conbench-apache-arrow Bot commented Nov 28, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

alinaliBQ commented Oct 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Rationale for this change

What changes are included in this PR?

Are these changes tested?

Are there any user-facing changes?

Uh oh!

alinaliBQ commented Oct 9, 2025

Uh oh!

github-actions Bot commented Oct 9, 2025

Uh oh!

lidavidm left a comment

Choose a reason for hiding this comment

Uh oh!

alinaliBQ commented Oct 21, 2025

Uh oh!

alinaliBQ commented Oct 22, 2025

Uh oh!

lidavidm Oct 23, 2025

Choose a reason for hiding this comment

Uh oh!

alinaliBQ Oct 28, 2025

Choose a reason for hiding this comment

Uh oh!

alinaliBQ left a comment

Choose a reason for hiding this comment

Uh oh!

alinaliBQ Oct 28, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

conbench-apache-arrow Bot commented Nov 28, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

alinaliBQ commented Oct 9, 2025 •

edited

Loading