GH-47520: [C++][Tensor] Correct sparse tensor creation from dense tensor with negative zero #47586
+429
−253
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
@rok, could you review this? |
rok
requested changes
Sep 22, 2025
Comment on lines
+201
to
+200
| ConvertRowMajorTensor<IndexType, ValueType>(tensor_, indices, values); | ||
| } else if (tensor_.is_column_major()) { | ||
| DISPATCH(CONVERT_COLUMN_MAJOR_TENSOR, index_elsize, value_elsize, indices, values, | ||
| nonzero_count); | ||
| ConvertColumnMajorTensor<IndexType, ValueType>(tensor_, indices, values, | ||
| nonzero_count); | ||
| } else { | ||
| DISPATCH(CONVERT_STRIDED_TENSOR, index_elsize, value_elsize, indices, values, | ||
| nonzero_count); | ||
| ConvertStridedTensor<IndexType, ValueType>(tensor_, indices, values); |
There was a problem hiding this comment.
Switching from DISPATCH to templates seems ok to me, but perhaps @pitrou can double-check?
github-actions
bot
added
awaiting changes
andishgar
force-pushed
the
resolve_negative_zero_in_sparse_tensor_creataion
branch
from
09c2259 to
8e7620f
Compare
github-actions
bot
added
awaiting change review
rok
reviewed
Sep 25, 2025
There was a problem hiding this comment.
Thanks for the update @andishgar !
I read through the logic and things look good to me. It's especially nice that element size calculations are no longer done by us. Some minor comments, but overall I think this is practically ready to merge.
I would now ask @pitrou to do a pass, especially on the template part.
github-actions
bot
added
awaiting review
andishgar
commented
Sep 26, 2025
|
|
||
| std::vector<int64_t> coords(2); | ||
| int64_t k = 0; | ||
| std::fill_n(indptr, index_elsize, 0); |
andishgar
force-pushed
the
resolve_negative_zero_in_sparse_tensor_creataion
branch
from
8e7620f to
c8c66e1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
As mentioned here case 1.
What changes are included in this PR?
Handle negative zero in sparse tensor creation.
Are these changes tested?
Yes, I ran the relevant unit tests.
Are there any user-facing changes?
No.
This PR contains a "Critical Fix".
(If the changes fix either (a) a security vulnerability, (b) a bug that causes incorrect or invalid data to be produced, or (c) a bug that causes a crash—even when the API contract is upheld—please provide an explanation. If not, you can remove this.)
Reference: case 1