Skip to content

GH-46516: [CI][Python] Force Cython>3.1.1 for docs builds #46770

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kou merged 5 commits into from
Jun 10, 2025
Merged

GH-46516: [CI][Python] Force Cython>3.1.1 for docs builds #46770

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
7873a14
GH-46516: [CI][Python] Force Cython>3.1.1 if BUILD_DOCS_PYTHON=ON
raulcd Jun 10, 2025
a585118
Fix doctset
raulcd Jun 10, 2025
9ae6a91
Use --upgrade for conda cases where cython might have been installed …
raulcd Jun 10, 2025
574017c
Remove pip install for Cython 3.1.2 and add pin on docs/requirements.…
raulcd Jun 10, 2025
30263d0
Update alphabetical order
raulcd Jun 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions ci/scripts/python_build.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,6 +78,13 @@ export PYARROW_PARALLEL=${n_jobs}
export CMAKE_PREFIX_PATH
export LD_LIBRARY_PATH=${ARROW_HOME}/lib:${LD_LIBRARY_PATH}

# https://github.com/apache/arrow/issues/46516
# If we are building docs we force Cython>3.1.1 to avoid numpydoc
# failures due to Cython docstring being wrongly generated.
if [ "${BUILD_DOCS_PYTHON}" == "ON" ]; then
${PYTHON:-python} -m pip install --upgrade Cython>3.1.1

@pitrou pitrou Jun 10, 2025

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will that work properly if Cython was installed using conda?
Also, is this necessary at all?

@raulcd raulcd Jun 10, 2025

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will that work properly if Cython was installed using conda?

It does fix the existing failures which install Cython through conda, so the answer seems to be yes (without this it still fails) because the cached docker image installed Cython 3.1.1

Also, is this necessary at all?

I don't think we should merge that specific change, I was validating the existing failing CI jobs.
I think the bests course of action would be to force rebuild the underlying docker image so it is not caches and it installs Cython 3.1.2. I am asking on Zulip if someone has access to docker.io/apache/arrow-dev as rebuilding the image would fix the issue

fi

# https://github.com/apache/arrow/issues/41429
# TODO: We want to out-of-source build. This is a workaround. We copy
# all needed files to the build directory from the source directory
Expand Down
2 changes: 1 addition & 1 deletion python/pyarrow/types.pxi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4464,7 +4464,7 @@ def float16():
to a python list, the types of its elements will be ``np.float16``

>>> [type(val) for val in a.to_pylist()]
[<class 'numpy.float16'>, <class 'numpy.float16'>]
[<class 'float'>, <class 'float'>]
"""
return primitive_type(_Type_HALF_FLOAT)

Expand Down
Loading