Enable mock test#46735
Closed
alinaliBQ wants to merge 14 commits into
Closed
Conversation
Co-authored-by: rscales <robscales@icloud.com>
Add initial framework for odbc dll
- Add ARROW_FLIGHT_SQL_ODBC option. If we set `ARROW_FLIGHT_SQL_ODBC=ON`, the flightsql odbc folder will be built
- Add odbc api layer for entry_point.cc
- builds odbc dll file, with ODBC APIs exported in odbc.def
Address James' comments
Fix `odbcabstraction` build errors and partially fix `flightsql_odbc` errors
Fix boost-variant not found error
- Adding dependencies from odbc/vcpkg.json to cpp/vcpkg.json
- Fix whereami.cc and .h dependency; ported lates code
Update whereami.cc
- use `long` instead of `int64`. Fixed namespace issues.
- PR CI fix: Add `parquet-testing` back
Partial build fix for `flight_sql` folder
- Replaced `namespace arrow` and `namespace odbcabstraction` with `using namespace ...`
- fix flight_sql_connection.cc
Fix `util::nullopt` to use `std::nullopt`
- fix std::optional
- fix BufferReader
- Fix GetSchema
- fix json_converter.cc
- partial fix configuration.h
- partial fix get_info_cache.cc
- Fix winsock build error
- Comment out `flight_sql` files that cannot build
- Comment out configuration and unit tests
- Comment out get info cache and system trust store
Create initial odbc tests folder
Implement SQLAllocEnv
Fix cmake build
Implement SQLFreeEnv
Fix rest of build errors from `flightsql-odbc`
- Fix get info errors
- Fix for configuration window
- added odbcinst library
- Fix system trust store
- unit test fixes
- Add dependency of ARROW_COMPUTE. `arrow/compute/api.h` is used in
`flight_sql`. Adding `ARROW_COMPUTE=ON` during build fixed run time unit
tests failures.
Implement SQLAllocConnect and SQLFreeConnect
Fix build issue from static flight sql driver
Lint and code style fixes
Re-add deleted submodule parquet-testing
clang-format lint fix
cpplint lint fix
Exclude whereami in rat exclude list
C++/CLI lint fix
Update parquet-testing to match commit from `main`
Address Kou's comments
ODBC directory lint fixes
Catching the lint fixes outside of `flightsql-odbc` code
Fix build warnings that get treated as error
Implement SQLSetEnvAttr and SQLGetEnvAttr
Implement use of ExecuteWithDiagnostics
Doxygen Error Fixes and Address comments from Kou and James
Address comments from Kou
- Updates License.txt
- Update cmake toolchain
- Move whereami to `vendored`
- Use string_view instead of NOLINT std::string
Remove `whereami.cc` from arrow util build
We are building whereami.cc as part of odbc
Fix include headers to replace <> with ""
Address comments from James
Implement SQLGetDiagField
Implement stubs for SQLGetInfo, SQLGetDiagField and SQLGetDiagRec Separate RegisterDsn and UnregisterDsn from windows build Update code to save driver value from connection string Add ReadMes for ODBC and tests Fix test issues with string_view Address code reviews Update entry_points.cc to fix build issue Remove Dremio references Use emplace properly Address comment from Rob and add SQLDisconnect test case
Accidentally committed the change during git rebase
Tests are skipped for now.
Add todo to update logging system later Add logs
Add tests
Collaborator
Author
|
Sorry, wrong target branch |
github-actions
Bot
added
Component: C++
Component: FlightRPC
awaiting review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enable mock test.
Goal: