GH-46499: [CI][Crossbow][C++] Use apache/arrow for Meson#46501
Conversation
|
|
36044ff to
db197ec
Compare
db197ec to
2d21358
Compare
|
|
cd9d8d8 to
b036227
Compare
c8212e4 to
f55a515
Compare
24717c1 to
c3a2f66
Compare
c3a2f66 to
15f4a51
Compare
de096f5 to
5451478
Compare
70b1a97 to
14664aa
Compare
1a86e48 to
3d0628c
Compare
Hmm well I think this will prevent the dependencies from being automatically downloaded, but then you will have to have the dependency installed in the CI container some other way, so not sure that is really the fix. IIUC the error message is coming from tests that belong to bzip2. I think we can avoid running subproject tests if we change: to |
|
Can we disable bundled bzip2 tests entirely? In general, we don't want to build tests of bundled dependencies. For example: |
|
It seems that we can't disable tests... |
3d0628c to
aa2548d
Compare
|
Yep exactly - I can try to upstream a change to the wrapdb, but in its current state you cannot |
|
Though interestingly the bzip2 project has its own CMake and Meson configuration files upstream, and neither of them provide an option to disable tests: https://github.com/libarchive/bzip2/blob/1ea1ac188ad4b9cb662e3f8314673c63df95a589/CMakeOptions.txt We can probably start by requesting an option in that project directly |
|
It makes sense. Could you do it? |
|
Sure - see https://gitlab.com/bzip2/bzip2/-/issues/59 |
|
It seems that we can use This is ready. I'll merge this in a few days if nobody objects it. |
aa2548d to
0816cd8
Compare
|
No objection. I'll merge this. |
|
After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit b8c9f76. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about 2 possible false positives for unstable benchmarks that are known to sometimes produce them. |
Rationale for this change
We're using Crossbow to offload CI jobs to separated repository but it has some inconveniences. See #46014 for details.
What changes are included in this PR?
Use
CI: Extralabel to run Meson CI job as an extra CI job.Are these changes tested?
Yes.
Are there any user-facing changes?
No.