GH-46395: [C++][Statistics] Correct the Equal method for min and max in arrow::ArrayStatistics #46422
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@kou what is your view on |
kou
changed the title
|
It may be better that we add Could you start a discussion for this like #46396 ? |
|
I will open an issue for discussion soon |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
arrow::ArrayStatistics::Equalsdoes not handle double values forArrayStatistics::ValueTypecorrectlyWhat changes are included in this PR?
Remove
ArrayStatistics::operator==()Add
arrow::EqualOptions to arrow::ArrayStatistics::Eqauls()Add
arrow::ArrayStatistics::ApproximateEquals()Are these changes tested?
Yes, I run the relevant unit test
Are there any user-facing changes?
Yes.
This PR includes breaking changes to public APIs. (If there are any breaking changes to public APIs, please explain which changes are breaking. If not, you can remove this.)
Remove
ArrayStatistics::operator==()