GH-46398: [GLib] Add GArrowFixedShapeTensorDataType#ndim #46399
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
kou
reviewed
May 12, 2025
| @@ -2366,6 +2366,21 @@ garrow_fixed_shape_tensor_data_type_get_shape(GArrowFixedShapeTensorDataType *da | |||
| return arrow_shape.data(); | |||
| } | |||
|
|
|||
| /** | |||
| * garrow_fixed_shape_tensor_data_type_get_ndim: | |||
There was a problem hiding this comment.
Could you implement this as a property because this is not a complex type such as an array?
Could you use n_dims or n_dimensions instead of ndim?
There was a problem hiding this comment.
OK. Will try it.
github-actions
bot
added
awaiting changes
|
Requested change a little difficult for me. I will implement other methods (permutation, dim_names) at first. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
The C++ API implemented
FixedShapeTensor::ndim()instance method. GLib was not yet supported.What changes are included in this PR?
Add
GArrowFixedShapeTensorDataType#ndiminstance method.Are these changes tested?
Yes.
Are there any user-facing changes?
Yes.