-
Notifications
You must be signed in to change notification settings - Fork 3.7k
GH-46315 [C#] Apache Arrow Flight Middleware #46316
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
HackPoint
wants to merge
11
commits into
apache:main
Choose a base branch
from
HackPoint:feat/flight-csharp-middleware
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ing headers and cookie values - Implemented tests verifying that CookieMiddleware correctly captures and persists values from both headers and cookies. - Added CapturingCookieMiddleware and CapturingCookieMiddlewareFactory for validating middleware lifecycle. - Ensured middleware correctly processes cookie strings and validates persistence throughout the request lifecycle.
…s it will add up and force more GC calls)
|
…nto feat/flight-csharp-middleware # Conflicts: # csharp/Directory.Build.props # csharp/src/Apache.Arrow.Flight/Middleware/ClientCookieMiddleware.cs # csharp/src/Apache.Arrow.Flight/Middleware/ClientCookieMiddlewareFactory.cs # csharp/src/Apache.Arrow.Flight/Middleware/CookieManager.cs # csharp/src/Apache.Arrow.Flight/Middleware/Extensions/FlightMethodParser.cs # csharp/src/Apache.Arrow.Flight/Middleware/Extensions/StatusUtils.cs # csharp/src/Apache.Arrow.Flight/Middleware/Interceptors/ClientInterceptorAdapter.cs # csharp/test/Apache.Arrow.Flight.Tests/MiddlewareTests/ClientCookieMiddlewareTests.cs # csharp/test/Apache.Arrow.Flight.Tests/MiddlewareTests/Stubs/ClientCookieMiddlewareMock.cs
…r for cookie middleware - Remove unused and redundant files
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enhancement: Apache Arrow Flight Middleware in C#
Overview
This Pull Request enhances middleware support for Apache Arrow Flight using C#, focusing on improved metadata header management and propagation for better observability and extensibility. It also provides handling for HTTP/HTTPS communication.
Rationale for this Change
Effective middleware is critical for managing metadata headers, ensuring accurate request/response handling, and simplifying debugging in distributed systems. By improving middleware capabilities, we enhance reliability and observability, significantly benefiting developers and operational teams managing complex Flight-based applications.
What's Included in this PR?
Key Features
OnBeforeSendingHeaders
,OnHeadersReceived
,OnCallCompleted
).Impact
Are These Changes Tested?
Testing Overview
Unit Tests:
OnBeforeSendingHeaders
,OnHeadersReceived
,OnCallCompleted
).Integration Tests:
x-server-header
,Set-Cookie
) between client and server.End-to-End Tests:
Example Test Cases:
OnHeadersReceived
correctly captures server-sent headers.OnCallCompleted
is triggered on both success and error cases.Checklist