Skip to content

GH-30774: [Python] Remove deprecated use_async#34034

Merged
jorisvandenbossche merged 2 commits into
apache:masterfrom
Fokko:fd-remove-async
Feb 7, 2023
Merged

GH-30774: [Python] Remove deprecated use_async#34034
jorisvandenbossche merged 2 commits into
apache:masterfrom
Fokko:fd-remove-async

Conversation

@Fokko

@Fokko Fokko commented Feb 3, 2023 •
edited by jorisvandenbossche
Loading

Copy link
Copy Markdown
Contributor

Has been deprecated since Arrow 7.0.0, time to make things nice and clean:

https://issues.apache.org/jira/browse/ARROW-13554

@Fokko Fokko requested a review from AlenkaF as a code owner February 3, 2023 16:46
@github-actions

github-actions Bot commented Feb 3, 2023

Copy link
Copy Markdown

@github-actions

github-actions Bot commented Feb 3, 2023

Copy link
Copy Markdown

⚠️ GitHub issue #34033 has been automatically assigned in GitHub to PR creator.

@Fokko Fokko mentioned this pull request Feb 3, 2023
Merged
@Fokko
apacheGH-34033: [Python] Remove deprecated use_async
291ee19 
Has been deprecated since Arrow 7.0.0, time to make things nice and clean
@jorisvandenbossche jorisvandenbossche changed the title GH-34033: [Python] Remove deprecated use_async GH-30774: [Python] Remove deprecated use_async Feb 7, 2023
@jorisvandenbossche jorisvandenbossche added this to the 12.0.0 milestone Feb 7, 2023
@github-actions

github-actions Bot commented Feb 7, 2023

Copy link
Copy Markdown

@github-actions

github-actions Bot commented Feb 7, 2023

Copy link
Copy Markdown

⚠️ GitHub issue #30774 has been automatically assigned in GitHub to PR creator.

2 similar comments
@github-actions

github-actions Bot commented Feb 7, 2023

Copy link
Copy Markdown

⚠️ GitHub issue #30774 has been automatically assigned in GitHub to PR creator.

@github-actions

github-actions Bot commented Feb 7, 2023

Copy link
Copy Markdown

⚠️ GitHub issue #30774 has been automatically assigned in GitHub to PR creator.

jorisvandenbossche
jorisvandenbossche approved these changes Feb 7, 2023
View reviewed changes

@jorisvandenbossche jorisvandenbossche left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR, looks good!

(I just linked it to another older issue, since we already had one open about it (that is linked to from the original PR))

@jorisvandenbossche jorisvandenbossche merged commit 4e89d9a into apache:master Feb 7, 2023
@ursabot

ursabot commented Feb 8, 2023

Copy link
Copy Markdown

Benchmark runs are scheduled for baseline = 5c73ac8 and contender = 4e89d9a. 4e89d9a is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Failed ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2
[Failed ⬇️0.18% ⬆️0.03%] test-mac-arm
[Failed ⬇️0.0% ⬆️0.0%] ursa-i9-9960x
[Finished ⬇️0.13% ⬆️0.03%] ursa-thinkcentre-m75q
Buildkite builds:
[Failed] 4e89d9a8 ec2-t3-xlarge-us-east-2
[Failed] 4e89d9a8 test-mac-arm
[Failed] 4e89d9a8 ursa-i9-9960x
[Finished] 4e89d9a8 ursa-thinkcentre-m75q
[Finished] 5c73ac80 ec2-t3-xlarge-us-east-2
[Finished] 5c73ac80 test-mac-arm
[Finished] 5c73ac80 ursa-i9-9960x
[Finished] 5c73ac80 ursa-thinkcentre-m75q
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

js8544 added a commit to js8544/benchmarks that referenced this pull request Feb 9, 2023
@js8544
Remove use_async argument in dataset.to_table call
4c676c6 
The use_async parameter has been removed in apache/arrow#34034
@js8544 js8544 mentioned this pull request Feb 9, 2023
Merged
alistaire47 added a commit to voltrondata-labs/benchmarks that referenced this pull request Feb 9, 2023
@js8544 @alistaire47
Remove use_async argument in dataset.to_table call (#131)
75bc80e 
* Remove use_async argument in dataset.to_table call

The use_async parameter has been removed in apache/arrow#34034

* black

---------

Co-authored-by: Edward Visel <1693477+alistaire47@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jorisvandenbossche jorisvandenbossche jorisvandenbossche approved these changes
@AlenkaF AlenkaF Awaiting requested review from AlenkaF

Assignees

No one assigned

Labels

Component: Python

Projects

None yet

Milestone

12.0.0

Development

Successfully merging this pull request may close these issues.

[Python] Remove deprecated placeholders for UseAsync

3 participants

@Fokko @ursabot @jorisvandenbossche