Skip to content

chore: Focus on actual errors by removing -warnings-as-errors #53

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
dongjoon-hyun wants to merge 1 commit into from
Closed

chore: Focus on actual errors by removing -warnings-as-errors #53

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions .github/workflows/test.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,8 +86,6 @@ jobs:
run: |
docker compose build ubuntu
- name: Run
# We remove this when we support Swift 6.0 or later.
continue-on-error: ${{ matrix.swift-version != '5.10' }}
run: |
docker compose run --rm ubuntu
- name: Fix permission for .docker/
Expand Down
9 changes: 0 additions & 9 deletions ci/scripts/build.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,15 +57,6 @@ cp *.arrow ../../Arrow
popd
github_actions_group_end

github_actions_group_begin "Use -warnings-as-errors"
for package in . Arrow ArrowFlight; do
pushd "${build_dir}/source/${package}"
sed 's/\/\/ build://g' Package.swift > Package.swift.build
mv Package.swift.build Package.swift
popd
done
github_actions_group_end

github_actions_group_begin "Build"
pushd "${build_dir}/source"
swift build
Expand Down
Loading