Skip to content

[56_maintenance] Fix cargo_audit: Pin cargo-msrv and Cargo.lock in CI#9902

Merged
alamb merged 1 commit intoapache:56_maintenancefrom
alamb:alamb/fix_56_cargo_msrv
May 5, 2026
Merged

[56_maintenance] Fix cargo_audit: Pin cargo-msrv and Cargo.lock in CI#9902
alamb merged 1 commit intoapache:56_maintenancefrom
alamb:alamb/fix_56_cargo_msrv

Conversation

@alamb
Copy link
Copy Markdown
Contributor

@alamb alamb commented May 5, 2026

NOTE: almost all of this PR is Cargo.lock files. I swear it is easy to review...

Rationale

The MSRV check is failing on 56 (I saw on #989) due to the fact that many of arrow's dependencies have upgraded to a newer version of rust that has a newer MSRV.

Here is an example CI fail https://github.com/apache/arrow-rs/actions/runs/25373570591/job/74402867748?pr=9896

  Run if which cargo-msrv ; then echo "using existing cargo-msrv binary" ; else cargo
  install cargo-msrv ; fi
    if which cargo-msrv ; then echo "using existing cargo-msrv binary" ; else cargo install
  cargo-msrv ; fi
    shell: sh -e {0}
    env:
      RUSTFLAGS: -C debuginfo=1
      RUST_BACKTRACE: 1
      Updating crates.io index
  error: cannot install package `cargo-msrv 0.19.3`, it requires rustc 1.91.1 or newer,
  while the currently active rustc version is 1.89.0
  `cargo-msrv 0.18.4` supports rustc 1.85
  Error: Process completed with exit code 101.

This PR:

  • Pins cargo-msrv in the 56_maintenance MSRV CI job to a version compatible with the Rust toolchain used by the job
  • Checks in a Cargo.lock file so the older versions of the crate still run

Note this doesn't actually change any code in this crate. It simply updates the CI enough to get the tests to pass

@alamb alamb force-pushed the alamb/fix_56_cargo_msrv branch from afa70c6 to 0930939 Compare May 5, 2026 11:49
@alamb alamb changed the title [56_maintenance] Pin cargo-msrv in CI [56_maintenance] Fix cargo_audit: Pin cargo-msrv and Cargo.lock in CI May 5, 2026
@alamb alamb force-pushed the alamb/fix_56_cargo_msrv branch 2 times, most recently from 1d40d28 to 24d81da Compare May 5, 2026 14:06
@alamb
Copy link
Copy Markdown
Contributor Author

alamb commented May 5, 2026

Thank you @viirya

@alamb alamb merged commit d43dd67 into apache:56_maintenance May 5, 2026
33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants