Update test_variant_get_error_when_cast_failure... tests to uses a valid VariantArray
#8921
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alamb
changed the title
VariantArray
alamb
changed the title
VariantArraytest_variant_get_error_when_cast_failure... tests to uses a valid VariantArray
alamb
commented
Nov 25, 2025
| let mut builder = VariantArrayBuilder::new(3); | ||
| // 86401000000 is invalid for Time64Microsecond (max is 86400000000) | ||
| Time64MicrosecondArray::from(vec![ | ||
| Some(86401000000), |
Contributor
Author
There was a problem hiding this comment.
This is an invalid Time64MicrosecondArray and thus I would expect this array to be impossible to create with shred_variant (I would expect shred_variant to error)
| err.to_string().contains( | ||
| "Cast error: Cast failed at index 0 (array type: Time64(µs)): Invalid microsecond from midnight: 86401000000" | ||
| ) | ||
| "Cast error: Failed to extract primitive of type Time64(µs) from variant Int64(86401000000) at path VariantPath([])" |
Contributor
Author
There was a problem hiding this comment.
the case still errors, but the message is different
XiangpengHao
approved these changes
Nov 26, 2025
Contributor
Author
|
FYI @scovich @friendlymatthew , @klion26 and @codephage2020 |
friendlymatthew
approved these changes
Nov 26, 2025
Contributor
friendlymatthew
left a comment
friendlymatthew
left a comment
There was a problem hiding this comment.
Makes sense to me
klion26
approved these changes
Nov 27, 2025
Member
klion26
left a comment
klion26
left a comment
There was a problem hiding this comment.
Thanks for the improvement, LGTM
Contributor
Author
|
Thanks @klion26 and @XiangpengHao |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
variant_getperformance on a perfect shredding #8887Rationale for this change
In this comment here: #8887 (comment)
One of the tests intended to cover the behavior of CastOptions actually contains an invalid Shredded variant (the values could not have been shredded successfully because the integer values are out of range)
My understanding is that the test is intended to illustrate that casting fails when a non-shredded variant into a shredded variant. Thus, it would not have been possible to create the incorrect shredded variant in the first place (there would have been an error during shredding)
What changes are included in this PR?
Are these changes tested?
Only tests
Are there any user-facing changes?
None -- this is a test only change