Replace concat_elements_utf8_many BufferBuilders with Vec - #10633
Open
cakeni wants to merge 1 commit into
Open
Conversation
Rich-T-kid
approved these changes
Aug 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
OffsetBufferBuilder/BufferBuilderusage withVec, when possible #10245.Rationale for this change
Using
Vecinstead ofBufferBuildercan benefit from Rust's optimized vector implementation. This updates the value and offset builders inconcat_elements_utf8_many.What changes are included in this PR?
extend_from_sliceandpushwhile preserving the existing offset iteration.ArrayDataBuilder.Are these changes tested?
Yes. The following checks pass:
cargo +stable-x86_64-pc-windows-gnu fmt --all -- --checkcargo +stable-x86_64-pc-windows-gnu clippy -p arrow-string --all-targets --all-features --no-deps -- -D warningscargo +stable-x86_64-pc-windows-gnu test -p arrow-string --all-features(182 unit tests and 10 doctests passed)Are there any user-facing changes?
No.