Skip to content

chore(r): Remove support for deprecated vctrs::partial_frame #827

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
paleolimbot merged 2 commits into from
Nov 21, 2025
Merged

chore(r): Remove support for deprecated vctrs::partial_frame #827

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
59c202a
remove partial frame test and add note
paleolimbot Nov 20, 2025
2141177
add issue
paleolimbot Nov 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions r/R/convert-array.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -157,6 +157,8 @@ convert_array.nanoarrow_vctr <- function(array, to, ...) {

#' @export
convert_array.vctrs_partial_frame <- function(array, to, ...) {
# The vctrs::partial_frame() is scheduled for removal in future vctrs
# https://github.com/apache/arrow-nanoarrow/issues/825
ptype <- infer_nanoarrow_ptype(array)
if (!is.data.frame(ptype)) {
stop_cant_convert_array(array, to)
Expand Down
12 changes: 0 additions & 12 deletions r/tests/testthat/test-convert-array.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,18 +79,6 @@ test_that("convert to vector works for data.frame", {
)
})

test_that("convert to vector works for partial_frame", {
skip_if_not_installed("vctrs")

array <- as_nanoarrow_array(
data.frame(a = 1L, b = "two", stringsAsFactors = FALSE)
)
expect_identical(
convert_array(array, vctrs::partial_frame()),
data.frame(a = 1L, b = "two", stringsAsFactors = FALSE)
)
})

test_that("convert to vector works for extension<struct> -> data.frame()", {
array <- nanoarrow_extension_array(
data.frame(x = c(TRUE, FALSE, NA, FALSE, TRUE)),
Expand Down
Loading