fix(flight): reject Basic credentials without a separator#942
Merged
zeroshade merged 1 commit intoJul 15, 2026
Merged
Conversation
fallintoplace
force-pushed
the
fix/flight-basic-auth-credentials
branch
from
July 15, 2026 04:09
5254b37 to
f26e21c
Compare
zeroshade
approved these changes
Jul 15, 2026
zeroshade
left a comment
zeroshade
left a comment
Member
There was a problem hiding this comment.
LGTM — verified the fix and its test coverage. Thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
A valid Base64 Basic credential without a colon decoded to a one-element slice. The streaming authentication interceptor then indexed the missing password and panicked.
What changes are included in this PR?
Use
strings.Cutto split the decoded username and password, and return an Unauthenticated error when the separator is absent. Empty usernames and passwords remain validator policy.Are these changes tested?
Yes. Regression cases cover empty input, a username without a separator, empty username/password values, and passwords containing additional colons.
go test ./arrow/flightpasses.Are there any user-facing changes?
Malformed Basic credentials now return Unauthenticated instead of panicking.