fix(flight): reject malformed unary bearer headers#941
Merged
zeroshade merged 1 commit intoJul 15, 2026
Conversation
fallintoplace
force-pushed
the
fix/flight-unary-bearer-auth
branch
from
July 15, 2026 03:51
1eefcb8 to
047ac64
Compare
fallintoplace
changed the title
zeroshade
approved these changes
Jul 15, 2026
zeroshade
left a comment
zeroshade
left a comment
Member
There was a problem hiding this comment.
LGTM — verified the fix and its test coverage. Thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
The unary bearer interceptor used a prefix check and then sliced past an assumed space. An authorization value containing exactly
Bearercould therefore panic, while values such asBearerX tokenwere treated as bearer credentials.What changes are included in this PR?
Parse the authorization scheme and credential separately, require the exact Bearer scheme and a non-empty credential, and reject malformed headers before invoking the validator. Additional spaces before the credential are accepted.
Are these changes tested?
Yes. Regression coverage includes missing headers, missing credentials, malformed schemes, and valid credentials separated by multiple spaces.
go test ./arrow/flightand the race-enabled package test pass.Are there any user-facing changes?
Missing or malformed bearer headers now return Unauthenticated instead of reaching the validator or panicking. Multiple spaces after the scheme are accepted.