Skip to content

fix(array): reject unsupported type IDs #925

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zeroshade merged 1 commit into from
Jul 12, 2026
Merged

fix(array): reject unsupported type IDs #925

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion arrow/array/array.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,7 +117,11 @@ func invalidDataType(data arrow.ArrayData) arrow.Array {

// MakeFromData constructs a strongly-typed array instance from generic Data.
func MakeFromData(data arrow.ArrayData) arrow.Array {
return makeArrayFn[byte(data.DataType().ID()&0x3f)](data)
id := data.DataType().ID()
if id < 0 || int(id) >= len(makeArrayFn) || makeArrayFn[id] == nil {
return invalidDataType(data)
}
return makeArrayFn[id](data)
}

// NewSlice constructs a zero-copy slice of the array with the indicated
Expand Down
5 changes: 5 additions & 0 deletions arrow/array/array_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,7 @@ func (testDataType) Layout() arrow.DataTypeLayout { return arrow.DataTypeLayout{
func (testDataType) String() string { return "" }

func TestMakeFromData(t *testing.T) {
const veryLargeTypeID arrow.Type = 1 << 30
tests := []struct {
name string
d arrow.DataType
Expand Down Expand Up @@ -134,6 +135,10 @@ func TestMakeFromData(t *testing.T) {
// invalid types
{name: "invalid(-1)", d: &testDataType{arrow.Type(-1)}, expPanic: true, expError: "invalid data type: Type(-1)"},
{name: "invalid(63)", d: &testDataType{arrow.Type(63)}, expPanic: true, expError: "invalid data type: Type(63)"},
{name: "invalid(64)", d: &testDataType{arrow.Type(64)}, expPanic: true, expError: "invalid data type: Type(64)"},
{name: "invalid(65)", d: &testDataType{arrow.Type(65)}, expPanic: true, expError: "invalid data type: Type(65)"},
{name: "invalid(127)", d: &testDataType{arrow.Type(127)}, expPanic: true, expError: "invalid data type: Type(127)"},
{name: "invalid(very large)", d: &testDataType{veryLargeTypeID}, expPanic: true, expError: "invalid data type: Type(1073741824)"},
}
for _, test := range tests {
t.Run(test.name, func(t *testing.T) {
Expand Down
Loading