Skip to content

fix(compute/exprs): avoid empty field reference panic #1130

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zeroshade merged 2 commits into from
Aug 11, 2026
Merged

fix(compute/exprs): avoid empty field reference panic #1130

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8e5980a
fix(compute/exprs): avoid empty field reference panic
fallintoplace Aug 7, 2026
ff64959
test(compute/exprs): cover nested no-children detail
fallintoplace Aug 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 17 additions & 0 deletions arrow/compute/exprs/exec_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -340,6 +340,23 @@ func TestExecuteFieldRef(t *testing.T) {
}
}

func TestGetRefFieldEmptySchema(t *testing.T) {

@zeroshade zeroshade Aug 10, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor coverage gap: this pins the top-level empty case, but nothing pins the nested one. A future refactor that hoists the len(fields) == 0 check above the loop would silently drop the : <type> detail from nested references and this test would still pass.

A second case — a reference into a field whose type has no children, asserting the error still names the type — would guard the behaviour the fix went out of its way to preserve.

_, err := exprs.GetRefField(expr.NewStructFieldRef(0), nil)
assert.ErrorIs(t, err, compute.ErrNoChildren)
}

func TestGetRefFieldNestedNoChildren(t *testing.T) {
ref := &expr.StructFieldRef{
Field: 0,
Child: expr.NewStructFieldRef(0),
}
fields := []arrow.Field{{Name: "value", Type: arrow.PrimitiveTypes.Int32}}

_, err := exprs.GetRefField(ref, fields)
assert.ErrorIs(t, err, compute.ErrNoChildren)
assert.EqualError(t, err, compute.ErrNoChildren.Error()+": int32")
}

func TestExecuteScalarFuncCall(t *testing.T) {
mem := memory.NewCheckedAllocator(memory.NewGoAllocator())
fromJSON := func(ty arrow.DataType, json string) arrow.Array {
Expand Down
3 changes: 3 additions & 0 deletions arrow/compute/exprs/field_refs.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,9 @@ func GetRefField(ref expr.ReferenceSegment, fields []arrow.Field) (*arrow.Field,

for ref != nil {
if len(fields) == 0 {
if out == nil {
return nil, compute.ErrNoChildren
}
return nil, fmt.Errorf("%w: %s", compute.ErrNoChildren, out.Type)
}

Expand Down
Loading