fix(parquet/pqarrow): reject out-of-range INT96 timestamps - #1128
Draft
fallintoplace wants to merge 3 commits into
Draft
fix(parquet/pqarrow): reject out-of-range INT96 timestamps#1128fallintoplace wants to merge 3 commits into
fallintoplace wants to merge 3 commits into
Conversation
fallintoplace
marked this pull request as ready for review
August 7, 2026 22:13
fallintoplace
marked this pull request as draft
August 7, 2026 22:18
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
transferInt96 converts Parquet INT96 values through time.Time.UnixNano without checking the int64 nanosecond range. Very wide dates can therefore wrap when read as Arrow timestamp[ns].
What changes are included in this PR?
Add checked INT96 to nanosecond conversion, propagate conversion errors through the Parquet reader, and normalize Int96.ToTime without overflowing before the range check.
Are these changes tested?
go test ./parquet/pqarrow -run 'Test(ArrowTimestampToImpalaTimestamp|ReadInt96RejectsOutOfRangeTimestamp|WriteArrowInt96)$'Are there any user-facing changes?
In-range INT96 behavior is unchanged. Out-of-range INT96 timestamps now return an error instead of being wrapped.