fix(parquet/metadata): handle invalid row-group column indexes - #1125
Merged
zeroshade merged 3 commits intoAug 12, 2026
Merged
Conversation
fallintoplace
marked this pull request as ready for review
August 8, 2026 15:52
zeroshade
approved these changes
Aug 12, 2026
zeroshade
left a comment
zeroshade
left a comment
Member
There was a problem hiding this comment.
The row-group metadata accessors now handle negative and oversized column indexes without panicking, while preserving valid-index behavior. The new regression coverage exercises all three accessors, and the broader Parquet suite passes. Looks good.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
RowGroupMetaData.ColumnChunk returns an error but currently panics for invalid indexes. The column and offset index location helpers also index the underlying Thrift slice directly.
What changes are included in this PR?
Return an arrow.ErrIndex error from ColumnChunk for invalid indexes, and return false from the location helpers when the index is outside the row-group range.
Are these changes tested?
go test ./parquet/metadataAre there any user-facing changes?
Invalid row-group column indexes are handled as normal errors or missing locations instead of panics.