fix(arrow/array/arreflect): reject unrepresentable timestamps - #1123
Merged
zeroshade merged 2 commits intoAug 14, 2026
Conversation
fallintoplace
marked this pull request as ready for review
August 12, 2026 22:42
zeroshade
approved these changes
Aug 14, 2026
zeroshade
left a comment
zeroshade
left a comment
Member
There was a problem hiding this comment.
The boundary math is exactly right — including the tricky truncated-division min case where MinInt64 sits one second below MinInt64/multiplier with a fractional offset. The per-unit boundary tests at ±1 unit around MaxInt64/MinInt64 and the negative fractional-second cases give me full confidence. Good fix.
This review was drafted with the help of an AI-assisted tool and may contain mistakes; it was reviewed and confirmed by an Apache Arrow maintainer before posting. See the contributing guide for what the project considers a maintainer review.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
arreflect converts time.Time values through UnixNano for every timestamp unit. Dates outside the nanosecond range can therefore wrap instead of reporting that the value is not representable.
What changes are included in this PR?
Use the target timestamp unit during conversion and check the integer range before appending the value.
Are these changes tested?
go test ./arrow/array/arreflectgo test ./arrow -run 'TestTimestamp|TestDate'Are there any user-facing changes?
Unrepresentable time.Time values now return an error instead of producing a wrapped timestamp.