fix(arrow/scalar): format interval scalars in String - #1115
Merged
Conversation
fallintoplace
changed the title
fallintoplace
changed the title
fallintoplace
force-pushed
the
fix/scalar-interval-string
branch
from
August 6, 2026 17:36
b9159d0 to
905598d
Compare
zeroshade
approved these changes
Aug 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
String returns three dots for valid interval scalars because the generic string cast is not supported. The DayTime error also reports the wrong interval type.
What changes are included in this PR?
Format month intervals directly and use the existing JSON representation for day-time and month-day-nano intervals. Correct the related error messages.
Are these changes tested?
go test ./arrow/scalarAre there any user-facing changes?
Yes. Interval scalar String output is now meaningful for the supported interval types.