fix(arrow/scalar): align timestamp timezone parsing - #1109
Open
fallintoplace wants to merge 10 commits into
Open
fix(arrow/scalar): align timestamp timezone parsing#1109fallintoplace wants to merge 10 commits into
fallintoplace wants to merge 10 commits into
Conversation
fallintoplace
marked this pull request as draft
August 7, 2026 10:16
fallintoplace
marked this pull request as ready for review
August 12, 2026 17:57
fallintoplace
marked this pull request as draft
August 12, 2026 17:58
fallintoplace
marked this pull request as ready for review
August 12, 2026 18:33
Member
|
@fallintoplace need to fix the failing tests |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
MakeScalarParam, ParseScalar, timestamp builders, JSON decoding, and typed CSV parsing should use the same timestamp timezone rules. This also adds support for Arrow fixed-offset timezone strings.
What changes are included in this PR?
TimestampType.GetZone.Utc.Are these changes tested?
go test ./arrow ./arrow/scalar ./arrow/array ./arrow/compute -count=1go test ./arrow/csv -run Timestamp -count=1go test -race ./arrow ./arrow/scalar ./arrow/array ./arrow/compute ./arrow/csv -run Timestamp -count=1Are there any user-facing changes?
Timestamp string parsing now rejects mismatched timezone presence:
Explicit offsets still determine the represented instant, and mixed-case UTC metadata remains accepted. CSV output now includes the offset for timezone-aware timestamps.