fix(arrow/ipc): validate file block framing and lengths - #1097
Merged
Conversation
fallintoplace
changed the title
fallintoplace
force-pushed
the
fix/ipc-file-block-framing
branch
from
August 5, 2026 23:59
37abb4e to
ab8519e
Compare
fallintoplace
changed the title
zeroshade
requested changes
Aug 6, 2026
zeroshade
approved these changes
Aug 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
IPC file footers contain metadata and body lengths, while each message also carries framing information. File readers currently check that footer ranges are readable but can accept messages whose framing and footer lengths disagree.
What changes are included in this PR?
Validate continuation and legacy metadata prefixes against the footer, reject EOS markers inside file blocks, compare Message.BodyLen with the footer body length, and reject body lengths that are not 8-byte aligned. Share the checks between regular and memory-mapped file readers.
Are these changes tested?
go test ./arrow/ipc -count=1Are there any user-facing changes?
Yes. Invalid IPC file framing and inconsistent footer lengths are now rejected by both file readers.