Skip to content

chore: Replace dtolnay/rust-toolchain with rustup #108

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kou merged 2 commits into from
Jul 21, 2026
+29 −31
Merged

chore: Replace dtolnay/rust-toolchain with rustup #108

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5258073
chore: Replace dtolnay/rust-toolchain with rustup
Benjamin-Philip Jul 20, 2026
262e467
Add licence header
Benjamin-Philip Jul 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 1 addition & 7 deletions .github/workflows/docs.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,9 +22,6 @@ on:

workflow_dispatch:

env:
RUST_TOOLCHAIN_VERSION: stable

jobs:
build:
name: Build Docs
Expand All @@ -37,14 +34,11 @@ jobs:
persist-credentials: false

- name: Install Rust
uses: dtolnay/rust-toolchain@4be7066ada62dd38de10e7b70166bc74ed198c30 # stable
with:
toolchain: "${{ env.RUST_TOOLCHAIN_VERSION }}"
run: cd ./native/arrow_format_nif/ && rustup toolchain install

- name: Cache Rust packages
uses: swatinem/rust-cache@c19371144df3bb44fab255c43d04cbc2ab54d1c4 # v2.9.1
with:
env-vars: "RUST_TOOLCHAIN_VERSION"
workspaces: |
native/arrow_format_nif

Expand Down
8 changes: 2 additions & 6 deletions .github/workflows/erlang.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,9 +67,7 @@ jobs:
persist-credentials: false

- name: Install Rust
uses: dtolnay/rust-toolchain@4be7066ada62dd38de10e7b70166bc74ed198c30 # stable
with:
toolchain: "${{ env.RUST_TOOLCHAIN_VERSION }}"
run: cd ./native/arrow_format_nif/ && rustup toolchain install

- name: Cache Rust packages
uses: swatinem/rust-cache@c19371144df3bb44fab255c43d04cbc2ab54d1c4 # v2.9.1
Expand Down Expand Up @@ -108,9 +106,7 @@ jobs:
persist-credentials: false

- name: Install Rust
uses: dtolnay/rust-toolchain@4be7066ada62dd38de10e7b70166bc74ed198c30 # stable
with:
toolchain: "${{ env.RUST_TOOLCHAIN_VERSION }}"
run: cd ./native/arrow_format_nif/ && rustup toolchain install

- name: Cache Rust packages
uses: swatinem/rust-cache@c19371144df3bb44fab255c43d04cbc2ab54d1c4 # v2.9.1
Expand Down
24 changes: 6 additions & 18 deletions .github/workflows/rust.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,9 +24,6 @@ on:
branches:
- main

env:
RUST_TOOLCHAIN_VERSION: stable

permissions:
contents: read

Expand All @@ -44,14 +41,11 @@ jobs:
with:
persist-credentials: false

- uses: dtolnay/rust-toolchain@4be7066ada62dd38de10e7b70166bc74ed198c30 # stable
with:
toolchain: "${{ env.RUST_TOOLCHAIN_VERSION }}"
components: clippy
- name: Install Rust
run: cd ./native/arrow_format_nif/ && rustup toolchain install

- uses: swatinem/rust-cache@c19371144df3bb44fab255c43d04cbc2ab54d1c4 # v2.9.1
with:
env-vars: "RUST_TOOLCHAIN_VERSION"
workspaces: |
native/arrow_format_nif

Expand All @@ -71,14 +65,11 @@ jobs:
with:
persist-credentials: false

- uses: dtolnay/rust-toolchain@4be7066ada62dd38de10e7b70166bc74ed198c30 # stable
with:
toolchain: "${{ env.RUST_TOOLCHAIN_VERSION }}"
components: rustfmt
- name: Install Rust
run: cd ./native/arrow_format_nif/ && rustup toolchain install

- uses: swatinem/rust-cache@c19371144df3bb44fab255c43d04cbc2ab54d1c4 # v2.9.1
with:
env-vars: "RUST_TOOLCHAIN_VERSION"
workspaces: |
native/arrow_format_nif

Expand All @@ -98,14 +89,11 @@ jobs:
with:
persist-credentials: false

- uses: dtolnay/rust-toolchain@4be7066ada62dd38de10e7b70166bc74ed198c30 # stable
with:
toolchain: "${{ env.RUST_TOOLCHAIN_VERSION }}"
components: rustfmt
- name: Install Rust
run: cd ./native/arrow_format_nif/ && rustup toolchain install

- uses: swatinem/rust-cache@c19371144df3bb44fab255c43d04cbc2ab54d1c4 # v2.9.1
with:
env-vars: "RUST_TOOLCHAIN_VERSION"
workspaces: |
native/arrow_format_nif

Expand Down
20 changes: 20 additions & 0 deletions native/arrow_format_nif/rust-toolchain.toml
View file
Open in desktop

@kou kou Jul 20, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add our license header?

Original file line number Diff line number Diff line change
@@ -0,0 +1,20 @@
# Licensed to the Apache Software Foundation (ASF) under one
# or more contributor license agreements. See the NOTICE file
# distributed with this work for additional information
# regarding copyright ownership. The ASF licenses this file
# to you under the Apache License, Version 2.0 (the
# "License"); you may not use this file except in compliance
# with the License. You may obtain a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing,
# software distributed under the License is distributed on an
# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
# KIND, either express or implied. See the License for the
# specific language governing permissions and limitations
# under the License.

[toolchain]
channel = "stable"
components = ["clippy", "rustfmt"]