fix(python/adbc_driver_manager): pass table_types filter to GetObjects - #4712
Merged
Conversation
fornwall
force-pushed
the
get-objects-table-types
branch
from
August 23, 2026 06:38
8d77f96 to
864a25b
Compare
The Cython binding accepted table_types but always passed NULL to AdbcConnectionGetObjects, so the DB-API table_types_filter was silently ignored. Convert the sequence to the null-terminated const char** the C API expects, keeping the encoded strings alive for the duration of the call, and add coverage proving multiple table types reach the driver. Signed-off-by: Fredrik Fornwall <fredrik@fornwall.net>
fornwall
force-pushed
the
get-objects-table-types
branch
from
August 23, 2026 06:45
864a25b to
5660845
Compare
lidavidm
approved these changes
Aug 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Cython binding accepted table_types but always passed
NULLtoAdbcConnectionGetObjects, so the DB-APItable_types_filterwas silently ignored.Convert the sequence to the null-terminated
const char**the C API expects, keeping the encoded strings alive for the duration of the call, and add coverage proving multiple table types reach the driver.