Skip to content

feat(go/adbc): refactor logging instrumentation into OTel tracing - part 2/3 #4659

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
birschick-bq wants to merge 22 commits into
base: main
Choose a base branch
from
Open

feat(go/adbc): refactor logging instrumentation into OTel tracing - part 2/3 #4659

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
22 commits
Select commit Hold shift + click to select a range
b4f536c
feat(go/adbc): extend tracing lifecycle helpers
v-birschick-msft Aug 4, 2026
0214000
feat(go/adbc): add Flight SQL tracing utilities
v-birschick-msft Aug 4, 2026
0398194
feat(go/adbc): trace Flight SQL record readers
v-birschick-msft Aug 4, 2026
d951702
feat(go/adbc): trace Flight SQL connections
v-birschick-msft Aug 4, 2026
7974884
fix codespell finding
v-birschick-msft Aug 4, 2026
fb5fd6c
Merge branch 'dev/birschick-bq/flight-sql-log-to-trace-3-reader' into…
v-birschick-msft Aug 4, 2026
bc3dffb
remove unused methods (golangci findings)
v-birschick-msft Aug 4, 2026
8f08d10
remove unused methods (golangci-lint finding)
v-birschick-msft Aug 4, 2026
e3edd42
empty - retest
v-birschick-msft Aug 4, 2026
2e1088b
remove unused methods (golangci-lint findings)
v-birschick-msft Aug 4, 2026
cb93aa4
remove unused type (golangci-lint finding)
v-birschick-msft Aug 4, 2026
8446e81
improvements from code review comments
v-birschick-msft Aug 11, 2026
d602600
empty - retest
v-birschick-msft Aug 11, 2026
7165bc7
Address code review comment to add documentation for EndSpanHelper
v-birschick-msft Aug 17, 2026
f39374b
Merge branch 'dev/birschick-bq/flight-sql-log-to-trace-3-reader' into…
v-birschick-msft Aug 18, 2026
7809374
add unsaved changes
v-birschick-msft Aug 18, 2026
85bd804
correct test failure
v-birschick-msft Aug 18, 2026
1cf5b4b
empty - retest
v-birschick-msft Aug 19, 2026
a80a4d7
Merge branch 'main' into dev/birschick-bq/flight-sql-log-to-trace-4-c…
v-birschick-msft Aug 19, 2026
47c5660
code review updates
v-birschick-msft Aug 20, 2026
d9c5c84
Merge remote-tracking branch 'upstream/main' into dev/birschick-bq/fl…
v-birschick-msft Aug 20, 2026
c4bf15c
inline single use closeTracing function
v-birschick-msft Aug 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions go/adbc/driver/flightsql/flightsql_adbc_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -368,8 +368,8 @@ func TestFlightSQLTracingProducesTraceFiles(t *testing.T) {
}

output := traceOutput.String()
require.Contains(t, output, "FlightSQLDatabase.Open")
require.Contains(t, output, "FlightSQLStatement.ExecuteQuery")
require.Contains(t, output, "FlightSQL.Database.Open")
require.Contains(t, output, "FlightSQL.Statement.ExecuteQuery")
}

// Run the test suite, but validating that a header set on the database is ALWAYS passed
Expand Down
Loading
Loading