feat: add validate API to standalone mode #12718
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
size:L
Revolyssup
requested review from
bzp2010,
membphis and
nic-6443
and removed request for
bzp2010
nic-6443
reviewed
Oct 31, 2025
apisix/admin/standalone.lua
Outdated
| }) | ||
| end | ||
|
|
||
| local function validate(ctx) |
Member
There was a problem hiding this comment.
can we reuse this new validate function in exist update function to reduce code duplicate between those two functions?
AlinsRan
reviewed
Nov 10, 2025
| for _, item in ipairs(items) do | ||
| -- prevent updating resource with the same ID | ||
| -- (e.g., service ID or other resource IDs) in a single request | ||
| local duplicated, err = check_duplicate(item, key, id_set) |
Contributor
There was a problem hiding this comment.
The logic of check_deuplicate exists twice, the first time in validate_configuration, and the second time is redundant.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provide a validate API for standalone mode that only validate input like admin api but does not save input to memory.
Required for ingress controller to validate plugin configurations that convert from CRD.
Checklist