feat: As a user, I want to include the request body in the opa-input, so that I can reason about its contents #11629

wistefan · 2024-10-08T14:06:48Z

Description

In order to make decisions based on the request body, the OPA-Plugin will also forward the body when configured to do so.

Fixes #11387

Checklist

I have explained the need for this PR and the problem it solves
I have explained the changes or the new features added to this PR
I have added tests corresponding to this change
I have updated the documentation to reflect this change
I have verified that this change is backward compatible (If not, please discuss on the APISIX mailing list first)

wistefan · 2024-11-06T11:22:07Z

Is there anything I can do to get this PR forward?

github-actions · 2025-01-06T10:05:32Z

This pull request has been marked as stale due to 60 days of inactivity. It will be closed in 4 weeks if no further activity occurs. If you think that's incorrect or this pull request should instead be reviewed, please simply write any comment. Even if closed, you can still revive the PR at any time or discuss it on the [email protected] list. Thank you for your contributions.

apisix/plugins/opa/helper.lua

moonming · 2025-01-07T03:43:03Z

@wistefan Please synchronize the master code to trigger all CI

wistefan · 2025-01-07T07:12:58Z

@wistefan Please synchronize the master code to trigger all CI

@moonming Thank you for the review, I updated.

LuciaCabanillasRodriguez · 2025-03-24T14:24:21Z

Hello! If I want this new implementation with the request body, what should I do?

Baoyuantop · 2025-03-25T02:37:18Z

Hi @wistefan, please synchronize the latest master branch code to trigger the test.

docs/en/latest/plugins/opa.md

apisix/plugins/opa/helper.lua

Baoyuantop · 2025-04-01T06:45:59Z

Hi @wistefan, please fix failed ci

Baoyuantop · 2025-04-03T05:43:31Z

Hi @wistefan, do you have time to continue working on this PR?

wistefan · 2025-04-03T06:39:37Z

@Baoyuantop Yes, most likely beginning of next week

wistefan · 2025-04-17T10:59:55Z

@Baoyuantop Could you please appove the ci workflows?

Baoyuantop · 2025-04-23T02:07:30Z

@wistefan, please fix failed ci

LuciaCabanillasRodriguez · 2025-05-07T15:45:48Z

Hello! What is the status of this?

Baoyuantop · 2025-05-08T03:02:41Z

Need to fix the failed CI, waiting for a response from the author.

LuciaCabanillasRodriguez · 2025-05-27T19:43:06Z

Hello! Any news?

wistefan · 2025-05-28T06:00:10Z

Hi, sorry I will take care as soon as I find time. @LuciaCabanillasRodriguez help would be very welcome, do you have the time to take a look at the test failures?

LuciaCabanillasRodriguez · 2025-06-09T13:59:40Z

Hi, sorry I will take care as soon as I find time. @LuciaCabanillasRodriguez help would be very welcome, do you have the time to take a look at the test failures?

Hello! I tried to push a file to fix one of the issues, but I received a forbidden message. In any case, I solved it locally by running:

make lint
./utils/reindex t/plugin/opa3.t

LuciaCabanillasRodriguez · 2025-06-09T14:15:59Z

Regarding the error in t/discovery/consul_dump.t, I see that the test fails because the expected response from Consul isn’t being returned:
got: ''
expected: '{"service_a":[{"host":"127.0.0.1","port":30511,"weight":1}]}'

It seems like either the service_a isn’t being registered properly in Consul during the test, or the endpoint isn’t responding as expected.

As for the other warnings and errors like:
failed to do SSL handshake: certificate verify failed
http_init(): failed to load the configuration: connection refused

These appear to be related to missing services (like Consul or Etcd) or SSL verification issues, but I’m not entirely sure how to fix it with certainty.

LuciaCabanillasRodriguez · 2025-06-17T09:38:38Z

Good! I could remove one issue, the other one remains! Any help?? I would need some guidance on how to fix it

Baoyuantop · 2025-06-18T01:43:52Z

Maybe we can merge the master branch.

LuciaCabanillasRodriguez · 2025-06-24T14:15:44Z

Maybe we can merge the master branch.
Is there any update here?

Baoyuantop · 2025-06-25T02:49:00Z

docs/en/latest/plugins/opa.md

 | keepalive         | boolean | False    | true    |               | When set to `true`, keeps the connection alive for multiple requests.                                                                                                                      |
 | keepalive_timeout | integer | False    | 60000ms | [1000, ...]ms | Idle time after which the connection is closed.                                                                                                                                            |
 | keepalive_pool    | integer | False    | 5       | [1, ...]ms    | Connection pool limit.                                                                                                                                                                     |
 | with_route        | boolean | False    | false   |               | When set to true, sends information about the current Route.                                                                                                                               |


Need to modify Chinese documents synchronously

Baoyuantop · 2025-06-25T02:49:35Z

docs/en/latest/plugins/opa.md

 | with_route        | boolean | False    | false   |               | When set to true, sends information about the current Route.                                                                                                                               |
 | with_service      | boolean | False    | false   |               | When set to true, sends information about the current Service.                                                                                                                             |
 | with_consumer     | boolean | False    | false   |               | When set to true, sends information about the current Consumer. Note that this may send sensitive information like the API key. Make sure to turn it on only when you are sure it is safe. |
+| with_body         | boolean | False    | false   |               | When set to true, sends the request body. |


The request body may contain sensitive information (passwords, API keys, etc.), so a security warning needs to be added.

I have just added a security warning

Baoyuantop · 2025-06-25T02:55:27Z

t/plugin/opa3.t

+POST /hello
+hello world
+--- response_body
+hello world


We need to verify the body data received by OPA during the test.

Should I do something?

You need to add more tests to verify this scenario.

Hi @wistefan, could you please take a look? I’m running into some issues with Nginx and would appreciate your help. Thanks!

Hi @LuciaCabanillasRodriguez, do you need any help with this?

Is there any update here??

The failed CI needs to be fixed. Once it's finished, I'll ask other maintainers to review it.

should I do something more??

Please submit additional fixes to ensure all CI tests pass.

Hi @wistefan, is there still time to deal with these?

dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. doc Documentation things enhancement New feature or request labels Oct 8, 2024

wistefan mentioned this pull request Oct 11, 2024

feat: As a user, I want to include the request body in the opa-input, so that I can reason about its contents #11387

Open

github-actions bot added the stale label Jan 6, 2025

moonming reviewed Jan 7, 2025

View reviewed changes

apisix/plugins/opa/helper.lua Outdated Show resolved Hide resolved

apisix/plugins/opa/helper.lua Outdated Show resolved Hide resolved

wistefan force-pushed the master branch from a0a86d3 to 60b1efe Compare January 15, 2025 08:45

github-actions bot removed the stale label Jan 27, 2025

Baoyuantop reviewed Mar 25, 2025

View reviewed changes

docs/en/latest/plugins/opa.md Outdated Show resolved Hide resolved

apisix/plugins/opa/helper.lua Outdated Show resolved Hide resolved

apisix/plugins/opa/helper.lua Outdated Show resolved Hide resolved

Baoyuantop added this to ⚡️ Apache APISIX Roadmap Mar 28, 2025

Baoyuantop moved this to 👀 In review in ⚡️ Apache APISIX Roadmap Mar 28, 2025

Baoyuantop moved this from 👀 In review to 🏗 In progress in ⚡️ Apache APISIX Roadmap Mar 28, 2025

Baoyuantop moved this from 🏗 In progress to 👀 In review in ⚡️ Apache APISIX Roadmap Mar 28, 2025

wistefan added 11 commits March 31, 2025 09:54

add body support for the opa plugin

5f05a50

fix method calls and test names

a04ec4b

fix linting issues

c86bc2c

fix tests

7b1a8b6

linting fixes

6eeaac5

fix linting

cea6be4

add doc

3aa6a48

clean

656a3f0

still lintign

13c775f

fix linter issues

73738b7

change the error call

cf69c83

wistefan added 2 commits April 17, 2025 09:10

Merge branch 'apache:master' into master

2cb43cb

fix typo

f01ac39

Baoyuantop added the wait for update wait for the author's response in this issue/PR label Apr 29, 2025

github-actions bot added the user responded label May 28, 2025

reindex opa3.t

c4fdd13

Baoyuantop assigned LuciaCabanillasRodriguez Jun 13, 2025

Baoyuantop removed wait for update wait for the author's response in this issue/PR user responded labels Jun 13, 2025

Baoyuantop reviewed Jun 25, 2025

View reviewed changes

LuciaCabanillasRodriguez added 3 commits June 25, 2025 14:50

security warning

463b92f

updated Chinese documentation

8f6bd31

updated Chinese documentation

e50d8df

Baoyuantop added the wait for update wait for the author's response in this issue/PR label Jul 7, 2025

Baoyuantop moved this from 👀 In review to 📋 Backlog in ⚡️ Apache APISIX Roadmap Jul 29, 2025

LuciaCabanillasRodriguez added 2 commits August 12, 2025 14:49

Update docker-compose.plugin.yml and opa3.t test

9502a18

Fix test index for opa3.t

8a27c08

feat: As a user, I want to include the request body in the opa-input, so that I can reason about its contents #11629

Are you sure you want to change the base?

feat: As a user, I want to include the request body in the opa-input, so that I can reason about its contents #11629

Uh oh!

Conversation

wistefan commented Oct 8, 2024

Description

Checklist

Uh oh!

wistefan commented Nov 6, 2024

Uh oh!

github-actions bot commented Jan 6, 2025

Uh oh!

Uh oh!

Uh oh!

moonming commented Jan 7, 2025

Uh oh!

wistefan commented Jan 7, 2025

Uh oh!

LuciaCabanillasRodriguez commented Mar 24, 2025

Uh oh!

Baoyuantop commented Mar 25, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Baoyuantop commented Apr 1, 2025

Uh oh!

Baoyuantop commented Apr 3, 2025

Uh oh!

wistefan commented Apr 3, 2025

Uh oh!

wistefan commented Apr 17, 2025

Uh oh!

Baoyuantop commented Apr 23, 2025

Uh oh!

LuciaCabanillasRodriguez commented May 7, 2025

Uh oh!

Baoyuantop commented May 8, 2025

Uh oh!

LuciaCabanillasRodriguez commented May 27, 2025

Uh oh!

wistefan commented May 28, 2025

Uh oh!

LuciaCabanillasRodriguez commented Jun 9, 2025

Uh oh!

LuciaCabanillasRodriguez commented Jun 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

LuciaCabanillasRodriguez commented Jun 17, 2025

Uh oh!

Baoyuantop commented Jun 18, 2025

Uh oh!

LuciaCabanillasRodriguez commented Jun 24, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

LuciaCabanillasRodriguez commented Jun 9, 2025 •

edited

Loading