Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Copy code button #1239

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from
Open

feat: Copy code button #1239

wants to merge 2 commits into from

Conversation

codewec
Copy link

@codewec codewec commented Jan 31, 2025

#1211

copy.code.mov

@LinkinStars LinkinStars requested a review from robinv8 February 5, 2025 02:55
@shuashuai
Copy link
Member

#1211

copy.code.mov

First of all, thank you very much for your contribution. If you only look at the copy function, this contribution is perfect, but considering the code processing logic, the integrity of scene coverage, and the semantics.

  1. ImageViewer component is used to handle global image enlargement and image exception styles. It is not appropriate to place the copy function code here.
  2. The content of the ImageViewer package cannot completely cover all scenarios in the project that use the pre tag processing. All places in the project that use rich text rendering use htmlRender function, you can search globally to view the used scenes.
  3. I also implemented a copy function in the previous article, you can refer to this commit, but I prefer the animation you implement copy, which feels more elegant than the tooltip I use, or you can try combining these two solutions to achieve better Copy effect.

If you have any other questions, you are welcome to continue the discussion. I will do my best to help you.

@shuashuai shuashuai requested review from shuashuai and removed request for robinv8 February 6, 2025 03:42
@codewec
Copy link
Author

codewec commented Feb 6, 2025

Thank you, I will look into your commit.

@codewec
Copy link
Author

codewec commented Feb 24, 2025

  1. I also implemented a copy function in the previous article, you can refer to this commit, but I prefer the animation you implement copy, which feels more elegant than the tooltip I use, or you can try combining these two solutions to achieve better Copy effect.

The branch feat/1.4.3/ui will be merged into dev? Can I commit to feat/1.4.3/ui ?

@shuashuai
Copy link
Member

  1. I also implemented a copy function in the previous article, you can refer to this commit, but I prefer the animation you implement copy, which feels more elegant than the tooltip I use, or you can try combining these two solutions to achieve better Copy effect.

The branch feat/1.4.3/ui will be merged into dev? Can I commit to feat/1.4.3/ui ?

Yes, or you can resubmit the pr based on the test branch, since it's already merged into the test branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants