- 
                Notifications
    
You must be signed in to change notification settings  - Fork 358
 
[AMORO-3875] Support to build on Spark Scala-2.13 #3878
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
aa02c43    to
    7de47a5      
    Compare
  
    34c0fe1    to
    037dd89      
    Compare
  
    
          Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@             Coverage Diff              @@
##             master    #3878      +/-   ##
============================================
- Coverage     29.45%   28.93%   -0.52%     
+ Complexity     4236     3847     -389     
============================================
  Files           670      631      -39     
  Lines         55245    50721    -4524     
  Branches       6983     6496     -487     
============================================
- Hits          16273    14677    -1596     
+ Misses        37778    34985    -2793     
+ Partials       1194     1059     -135     
 Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
  | 
    
43f5980    to
    103bc9f      
    Compare
  
    save bin profile GA revert paimon ams api compatiblity fix flink scala style save save rewrite by scala save conflicts dependency save save scala paimon ignore paimon idea
| <configuration> | ||
| <excludes> | ||
| <!-- no paimon-spark on scala-2.13 released so far --> | ||
| <exclude>**/TestUnifiedCatalog.java</exclude> | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
new paimon-spark lib with scala.binary.binary has not been released.
Will update the paimon version for spark-3.5 after it released.
https://github.com/apache/paimon/blob/f919aa82feb89b60d08b6fb7ce8c38233d864b92/paimon-spark/paimon-spark-3.5/pom.xml#L31
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will update it after paimon 1.4.0 released (paimon 1.3.0 has not been released so far, in progress).
| import org.apache.amoro.spark.sql.utils.ProjectingInternalRow | ||
| 
               | 
          ||
| /** cast internal row to upsert internal row */ | ||
| class SparkInternalRowCastWrapper( | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
have to rewrite it in scala, otherwise, it is impossible to pass scala-2.13 compile
| 
           new commit just for minor change  | 
    
Why are the changes needed?
Close #3875.
Support to build amoro on scala-2.13.
Brief change log
How was this patch tested?
Add some test cases that check the changes thoroughly including negative and positive cases if possible
Add screenshots for manual tests if appropriate
Run test locally before making a pull request
Documentation