Skip to content

Conversation

@turboFei
Copy link
Member

@turboFei turboFei commented Nov 3, 2025

Why are the changes needed?

Close #3875.

Support to build amoro on scala-2.13.

Brief change log

  • Support to build amoro on scala-2.13.

How was this patch tested?

  • Add some test cases that check the changes thoroughly including negative and positive cases if possible

  • Add screenshots for manual tests if appropriate

  • Run test locally before making a pull request

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

@github-actions github-actions bot added module:mixed-spark Spark module for Mixed Format module:ams-server Ams server module module:ams-optimizer AMS optimizer module type:infra type:build labels Nov 3, 2025
@turboFei turboFei force-pushed the scala_213 branch 2 times, most recently from aa02c43 to 7de47a5 Compare November 3, 2025 06:19
@turboFei turboFei marked this pull request as draft November 3, 2025 06:24
@turboFei turboFei changed the title [AMORO-3875] Support to build on Scala-2.13 [AMORO-3875] Support to build on Spark-3.5 + Scala-2.13 Nov 3, 2025
@github-actions github-actions bot added the module:mixed-flink Flink moduel for Mixed Format label Nov 3, 2025
@turboFei turboFei force-pushed the scala_213 branch 2 times, most recently from 34c0fe1 to 037dd89 Compare November 3, 2025 18:49
@turboFei turboFei closed this Nov 3, 2025
@turboFei turboFei reopened this Nov 3, 2025
@codecov-commenter
Copy link

codecov-commenter commented Nov 3, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 28.93%. Comparing base (fd44c44) to head (857b7b4).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #3878      +/-   ##
============================================
- Coverage     29.45%   28.93%   -0.52%     
+ Complexity     4236     3847     -389     
============================================
  Files           670      631      -39     
  Lines         55245    50721    -4524     
  Branches       6983     6496     -487     
============================================
- Hits          16273    14677    -1596     
+ Misses        37778    34985    -2793     
+ Partials       1194     1059     -135     
Flag Coverage Δ
core 28.93% <ø> (+0.11%) ⬆️
trino ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@turboFei turboFei force-pushed the scala_213 branch 2 times, most recently from 43f5980 to 103bc9f Compare November 3, 2025 23:53
@turboFei turboFei marked this pull request as ready for review November 4, 2025 00:07
@turboFei turboFei changed the title [AMORO-3875] Support to build on Spark-3.5 + Scala-2.13 [AMORO-3875] Support to build on Spark with Scala-2.13 Nov 4, 2025
@turboFei turboFei changed the title [AMORO-3875] Support to build on Spark with Scala-2.13 [AMORO-3875] Support to build on Spark Scala-2.13 Nov 4, 2025
save

bin

profile

GA

revert paimon ams

api compatiblity

fix flink scala

style

save

save

rewrite by scala

save

conflicts

dependency

save

save

scala paimon

ignore paimon

idea
<configuration>
<excludes>
<!-- no paimon-spark on scala-2.13 released so far -->
<exclude>**/TestUnifiedCatalog.java</exclude>
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

new paimon-spark lib with scala.binary.binary has not been released.

Will update the paimon version for spark-3.5 after it released.
https://github.com/apache/paimon/blob/f919aa82feb89b60d08b6fb7ce8c38233d864b92/paimon-spark/paimon-spark-3.5/pom.xml#L31

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will update it after paimon 1.4.0 released (paimon 1.3.0 has not been released so far, in progress).

@turboFei turboFei closed this Nov 4, 2025
@turboFei turboFei reopened this Nov 4, 2025
import org.apache.amoro.spark.sql.utils.ProjectingInternalRow

/** cast internal row to upsert internal row */
class SparkInternalRowCastWrapper(
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

have to rewrite it in scala, otherwise, it is impossible to pass scala-2.13 compile

@turboFei
Copy link
Member Author

turboFei commented Nov 4, 2025

cc @xxubai @zhoujinsong

@turboFei
Copy link
Member Author

turboFei commented Nov 4, 2025

new commit just for minor change

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

module:ams-optimizer AMS optimizer module module:ams-server Ams server module module:mixed-flink Flink moduel for Mixed Format module:mixed-spark Spark module for Mixed Format type:build type:infra

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Improvement]: Support to build on Scala-2.13

2 participants