- 
                Notifications
    
You must be signed in to change notification settings  - Fork 358
 
[AMORO-3872] Support to customize basic authentication implementation #3871
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
          Codecov Report❌ Patch coverage is  Additional details and impacted files@@             Coverage Diff              @@
##             master    #3871      +/-   ##
============================================
+ Coverage     28.82%   29.03%   +0.21%     
- Complexity     3838     3861      +23     
============================================
  Files           625      634       +9     
  Lines         50514    50808     +294     
  Branches       6455     6545      +90     
============================================
+ Hits          14560    14752     +192     
- Misses        34928    34998      +70     
- Partials       1026     1058      +32     
 Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
  | 
    
ad2fffb    to
    fe1aec7      
    Compare
  
            
          
                amoro-common/src/main/java/org/apache/amoro/spi/PasswdAuthenticationProvider.java
              
                Outdated
          
            Show resolved
            Hide resolved
        
      b5e5825    to
    514050b      
    Compare
  
    514050b    to
    8c7f5ee      
    Compare
  
    8c7f5ee    to
    d01b0cd      
    Compare
  
    There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| 
           not familiar with the internals of this project, the API   | 
    
Why are the changes needed?
Close #3872.
Support to customize basic authentication implementation.
Brief change log
How was this patch tested?
Add some test cases that check the changes thoroughly including negative and positive cases if possible
Add screenshots for manual tests if appropriate
Run test locally before making a pull request
Documentation