Skip to content

Conversation

@turboFei
Copy link
Member

@turboFei turboFei commented Nov 2, 2025

Why are the changes needed?

Close #3872.
Support to customize basic authentication implementation.

Brief change log

  • Support to customize basic authentication implementation

How was this patch tested?

  • Add some test cases that check the changes thoroughly including negative and positive cases if possible

  • Add screenshots for manual tests if appropriate

  • Run test locally before making a pull request

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

@github-actions github-actions bot added the module:ams-server Ams server module label Nov 2, 2025
@turboFei turboFei changed the title Password auth Support to customize basic authentication implementation Nov 2, 2025
@turboFei turboFei changed the title Support to customize basic authentication implementation [AMORO-3872] Support to customize basic authentication implementation Nov 2, 2025
@github-actions github-actions bot added the type:docs Improvements or additions to documentation label Nov 2, 2025
@codecov-commenter
Copy link

codecov-commenter commented Nov 2, 2025

Codecov Report

❌ Patch coverage is 53.33333% with 21 lines in your changes missing coverage. Please review.
✅ Project coverage is 29.03%. Comparing base (17b68d0) to head (d8157fb).

Files with missing lines Patch % Lines
...pache/amoro/spi/authentication/BasicPrincipal.java 0.00% 13 Missing ⚠️
...apache/amoro/server/dashboard/DashboardServer.java 36.36% 6 Missing and 1 partial ⚠️
...rver/authentication/HttpAuthenticationFactory.java 88.88% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #3871      +/-   ##
============================================
+ Coverage     28.82%   29.03%   +0.21%     
- Complexity     3838     3861      +23     
============================================
  Files           625      634       +9     
  Lines         50514    50808     +294     
  Branches       6455     6545      +90     
============================================
+ Hits          14560    14752     +192     
- Misses        34928    34998      +70     
- Partials       1026     1058      +32     
Flag Coverage Δ
core 29.03% <53.33%> (+0.21%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@turboFei turboFei marked this pull request as draft November 3, 2025 04:49
@turboFei turboFei changed the title [AMORO-3872] Support to customize basic authentication implementation [WIP][AMORO-3872] Support to customize basic authentication implementation Nov 3, 2025
@turboFei turboFei changed the title [WIP][AMORO-3872] Support to customize basic authentication implementation [AMORO-3872] Support to customize basic authentication implementation Nov 3, 2025
@turboFei turboFei marked this pull request as ready for review November 3, 2025 04:58
@turboFei turboFei closed this Nov 3, 2025
@turboFei turboFei reopened this Nov 3, 2025
@turboFei turboFei force-pushed the password_auth branch 3 times, most recently from b5e5825 to 514050b Compare November 4, 2025 04:30
@turboFei turboFei requested a review from pan3793 November 4, 2025 04:30
Copy link
Contributor

@xxubai xxubai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @turboFei @pan3793 . LGTM

@pan3793
Copy link
Member

pan3793 commented Nov 4, 2025

not familiar with the internals of this project, the API interface PasswdAuthenticationProvider lgtm.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

module:ams-server Ams server module module:common type:docs Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Improvement]: Support to customize basic authentication implementation

4 participants