Skip to content

[AMORO-3810] Fix tableRuntime initialize failed when not have optimizer info for table #3811

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

[AMORO-3810] Fix tableRuntime initialize failed when not have optimizer info for table #3811

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1fdca94
[AMORO-3810] Fix TableRuntime initialize failed when not have optimiz…
czy006 Oct 9, 2025
fd6d417
hot fixed
czy006 Oct 10, 2025
ceddb92
Merge branch 'master' into issues/AMORO-3819
czy006 Oct 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions amoro-ams/src/main/java/org/apache/amoro/server/table/DefaultTableService.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -182,6 +182,13 @@ public void initialize() {
continue;
}
List<TableRuntimeState> states = statesMap.get(tableRuntimeMeta.getTableId());
// if first time states will be null can't be initial table runtime
if (states == null) {
TableRuntimeState state = new TableRuntimeState();
Copy link
Contributor

@zhoujinsong zhoujinsong Oct 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we can just initialize an empty list here, https://github.com/apache/amoro/blob/master/amoro-ams/src/main/java/org/apache/amoro/server/table/DefaultTableRuntimeStore.java#L137 will generate required states and put them in the database.

Copy link
Contributor

@zhoujinsong zhoujinsong Oct 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc @baiyangtx

Copy link
Contributor

@baiyangtx baiyangtx Oct 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with that.

The initialization of states should be uniformly managed by the lifecycle logic of TableRuntime, and its default values have already been defined in StateKey.

Copy link
Contributor

@baiyangtx baiyangtx Oct 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Additionally, stateId and OptimizingStatus are not related. TableRuntimeState represents the persistent access interface of TableRuntime, while OptimizingStatus is part of the optimization logic of Iceberg and Mixed Iceberg. The two are unrelated.

Copy link
Contributor Author

@czy006 czy006 Oct 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When we persist tableuntime for the first time, do we need to set OptimizingStatus to IDLE by default? Or will the subsequent optimization triggers automatically supplement this status cc @baiyangtx @zhoujinsong

state.setStateId(OptimizingStatus.IDLE.getCode());
state.setTableId(tableRuntimeMeta.getTableId());
states = Collections.singletonList(state);
}
Optional<TableRuntime> tableRuntime =
createTableRuntime(identifier, tableRuntimeMeta, states);
if (!tableRuntime.isPresent()) {
Expand Down