Skip to content

Recreate missing SerializedDagModel for existing DagVersion to ensure DAGs can be re-serialized. Fixes #68947.#68950

Open
k4s2811 wants to merge 1 commit into
apache:mainfrom
k4s2811:fix-missing-serialized-dag
Open

Recreate missing SerializedDagModel for existing DagVersion to ensure DAGs can be re-serialized. Fixes #68947.#68950
k4s2811 wants to merge 1 commit into
apache:mainfrom
k4s2811:fix-missing-serialized-dag

Conversation

@k4s2811

@k4s2811 k4s2811 commented Jun 24, 2026

Copy link
Copy Markdown

Was generative AI tooling used to co-author this PR?
  • Yes (please specify the tool below)

  • Read the Pull Request Guidelines for more information. Note: commit author/co-author name and email in commits become permanently public when merged.
  • For fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
  • When adding dependency, check compliance with the ASF 3rd Party License Policy.
  • For significant user-facing changes create newsfragment: {pr_number}.significant.rst, in airflow-core/newsfragments. You can add this file in a follow-up commit after the PR is created so you know the PR number.

@boring-cyborg

boring-cyborg Bot commented Jun 24, 2026

Copy link
Copy Markdown

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide
Here are some useful points:

  • Pay attention to the quality of your code (ruff, mypy and type annotations). Our prek-hooks will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example Dag that shows how users should use it.
  • Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
  • Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: dev@airflow.apache.org
    Slack: https://s.apache.org/airflow-slack

@k4s2811 k4s2811 changed the title This PR fixes a case where a DagVersion exists but its SerializedDagModel row is missing. Previously, the in-place UPDATE path matched zero rows and returned False, preventing the DAG from being re-serialized on subsequent parses. As a result, the DAG could remain permanently unserialized. This change recreates the missing SerializedDagModel for the existing DagVersion and preserves the associated DagCode behavior. Tests Added coverage for re-serializing when SerializedDagModel is missing. Added coverage for the repair path when DagCode exists. Added coverage for the repair path when DagCode is also missing. Fixes #68947 Recreate missing SerializedDagModel for existing DagVersion to ensure DAGs can be re-serialized. Fixes #68947. Jun 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant