Remove stale metrics no longer emitted from the metrics registry#68945
Open
FrankYang0529 wants to merge 1 commit into
Open
Remove stale metrics no longer emitted from the metrics registry#68945FrankYang0529 wants to merge 1 commit into
FrankYang0529 wants to merge 1 commit into
Conversation
dag_processing.manager_stalls, dag_file_refresh_error, and collect_db_dags describe metrics whose emission was removed in earlier refactors (apache#45729, apache#44972, apache#53918) Signed-off-by: PoAn Yang <payang@apache.org>
SameerMesiah97
left a comment
SameerMesiah97
left a comment
Contributor
There was a problem hiding this comment.
I searched for these metrics in main and I could find them being emitted anywhere. I do wonder why they were not removed from .yaml file? I want to make sure removing them from the registry won't impact any tooling that relies on the template rather than the emitted metrics themselves. This looks fine to me but let's wait for a maintiainer to weigh in.
Lee-W
approved these changes
Jun 25, 2026
Lee-W
left a comment
Lee-W
left a comment
Member
There was a problem hiding this comment.
make sense to me. probably also worth a quick confirm from @ashb @jedcunningham and @uranusjr (the original author of the PRs).
we can also add a prek hook to check. e.g., if we add or remove a metrics, we trigger this hook to compare the metric in the doc and in the code
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove the three orphaned entries from
metrics_template.yaml:dag_processing.manager_stalls— emission removed in Remove dag processor from the scheduler #45729dag_file_refresh_error— emission removed in Swap Dag Parsing to use the TaskSDK machinery. #44972collect_db_dags— emission removed in Move DagBag to SDK and make it return SDK DAG objects #53918Was generative AI tooling used to co-author this PR?
{pr_number}.significant.rst, in airflow-core/newsfragments. You can add this file in a follow-up commit after the PR is created so you know the PR number.