Exclude non-successful runs from AVERAGE_RUNTIME deadline calculation#68647
Merged
o-nikolas merged 6 commits intoJun 24, 2026
Merged
Conversation
boring-cyborg
Bot
added
area:DAG-processing
area:deadline-alerts
potiuk
added
the
ready for maintainer review
ramitkataria
approved these changes
Jun 22, 2026
ferruzzi
approved these changes
Jun 22, 2026
ferruzzi
left a comment
ferruzzi
left a comment
Contributor
There was a problem hiding this comment.
Looks right. Approved pending green CI and resolving Ramit's comments.
added 4 commits
June 23, 2026 01:37
DeadlineReference.AVERAGE_RUNTIME computes a deadline from the average duration of past DAG runs, but the query filtered only on dag_id + start/end-date present — with no DagRun.state filter. Failed runs (which may have died fast or hung before failing) were folded into the average, skewing the computed deadline: a fast-failing history makes it too short (spurious misses), a slow-then-failed history makes it too long (real slowness never trips it). Filter the duration query to successful runs only. Add tests asserting failed runs are excluded from the average and that the deadline is skipped when too few successful runs exist.
The average and the min_runs threshold count successful runs only, so "previous Dag runs" / "completed runs" were imprecise. Generated-by: Claude Code (Opus 4.8) following the guidelines
seanghaeli
force-pushed
the
bugfix/average-runtime-deadline-success-only
branch
from
1fb1621 to
64355c4
Compare
Co-authored-by: Ramit Kataria <ramitkat@amazon.com>
Co-authored-by: Ramit Kataria <ramitkat@amazon.com>
Contributor
|
Hi maintainer, this PR was merged without a milestone set.
|
Contributor
Backport successfully created: v3-3-testNote: As of Merging PRs targeted for Airflow 3.X In matter of doubt please ask in #release-management Slack channel.
|
potiuk
pushed a commit
that referenced
this pull request
Jun 26, 2026
… calculation (#68647) DeadlineReference.AVERAGE_RUNTIME computes a deadline from the average duration of past DAG runs, but the query filtered only on dag_id + start/end-date present — with no DagRun.state filter. Failed runs (which may have died fast or hung before failing) were folded into the average, skewing the computed deadline: a fast-failing history makes it too short (spurious misses), a slow-then-failed history makes it too long (real slowness never trips it). Filter the duration query to successful runs only. Add tests asserting failed runs are excluded from the average and that the deadline is skipped when too few successful runs exist. --------- (cherry picked from commit 88e6110) Co-authored-by: Sean Ghaeli <58916776+seanghaeli@users.noreply.github.com> Co-authored-by: Sean Ghaeli <ghaeli@amazon.com> Co-authored-by: Ramit Kataria <ramitkat@amazon.com>
potiuk
pushed a commit
that referenced
this pull request
Jun 26, 2026
… calculation (#68647) (#68949) DeadlineReference.AVERAGE_RUNTIME computes a deadline from the average duration of past DAG runs, but the query filtered only on dag_id + start/end-date present — with no DagRun.state filter. Failed runs (which may have died fast or hung before failing) were folded into the average, skewing the computed deadline: a fast-failing history makes it too short (spurious misses), a slow-then-failed history makes it too long (real slowness never trips it). Filter the duration query to successful runs only. Add tests asserting failed runs are excluded from the average and that the deadline is skipped when too few successful runs exist. --------- (cherry picked from commit 88e6110) Co-authored-by: Sean Ghaeli <58916776+seanghaeli@users.noreply.github.com> Co-authored-by: Sean Ghaeli <ghaeli@amazon.com> Co-authored-by: Ramit Kataria <ramitkat@amazon.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For
AVERAGE_RUNTIMEdeadlines, exclude non-success dag runs in the average calculation