AIP-76: Consume task-emitted partition keys on asset events#66782
Open
anishgirianish wants to merge 1 commit into
Open
AIP-76: Consume task-emitted partition keys on asset events#66782anishgirianish wants to merge 1 commit into
anishgirianish wants to merge 1 commit into
Conversation
1 task
Lee-W
reviewed
May 13, 2026
| # tell the truth if for some reason it touches a different partition? | ||
| # https://github.com/apache/airflow/issues/58474 | ||
| partition_key = ti.dag_run.partition_key | ||
| events_by_asset: dict[SerializedAssetUniqueKey, list[tuple[dict, str | None]]] = defaultdict(list) |
Member
There was a problem hiding this comment.
it would be easier to read this way
Suggested change
| events_by_asset: dict[SerializedAssetUniqueKey, list[tuple[dict, str | None]]] = defaultdict(list) | |
| payloads_by_asset: dict[SerializedAssetUniqueKey, list[OutletEventPayload] = defaultdict(list) |
class OutletEventPayload(NamedTuple):
extra: dict
partition_key: str | None| partition_key = ti.dag_run.partition_key | ||
| events_by_asset: dict[SerializedAssetUniqueKey, list[tuple[dict, str | None]]] = defaultdict(list) | ||
| for outlet_event in outlet_events: | ||
| if "source_alias_name" in outlet_event: |
Member
There was a problem hiding this comment.
Suggested change
| if "source_alias_name" in outlet_event: | |
| # Alias-emitted events are handled separately further down via | |
| # register_asset_change_for_alias, which uses the DagRun-level | |
| # partition_key. Per-emission partition keys do not fan out through | |
| # the alias path — emission via an alias produces one event per | |
| # resolved asset, all carrying the same dag_run_partition_key. | |
| if "source_alias_name" in outlet_event: |
| runtime_pks: set[str] = { | ||
| pk for events in events_by_asset.values() for _, pk in events if pk is not None | ||
| } | ||
| if len(runtime_pks) == 1 and ti.dag_run.partition_key is None: |
Member
There was a problem hiding this comment.
let's also add a comment here to explain what we're doing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Was generative AI tooling used to co-author this PR?
Tasks can record per-emission partition keys via outlet_events[asset].add_partitions(...) (shipped in #65447).
Persist each on the matching AssetEvent row, fanning runtime fan-out emissions into one event per key, and back-fill
DagRun.partition_key when the task emitted exactly one key on a run that had none.
closes: #58474
related: #44146 #65300
cc @Lee-W
{pr_number}.significant.rst, in airflow-core/newsfragments. You can add this file in a follow-up commit after the PR is created so you know the PR number.