Param format='time' is unpassable: UI time picker omits seconds but jsonschema FormatChecker requires HH:MM:SS#66506
Closed
csrinivas2130 wants to merge 11 commits intoapache:mainfrom
Closed
Conversation
The check-newsfragment-pr-number CI job requires the newsfragment filename to match the PR number, not the linked issue number.
As per the suggestion, removed the bugfix file
Trialing space fix
csrinivas2130
requested review from
bbovenzi,
choo121600,
guan404ming,
pierrejeambrun,
ryanahamilton,
shubhamraj-git and
vatsrahul1001
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #66492
This fixes the issue Param format='time' is unpassable: UI time picker omits seconds but jsonschema FormatChecker requires HH:MM:SS #66492
What changed
FieldDateTime.tsx - edited (3 lines changed)
step={1} added for type="time" → browser shows the full HH:MM:SS picker
onChange pads HH:MM → HH:MM:SS for any value without seconds
value slice uses 8 chars for time, keeps 16 for everything else
FieldDateTime.test.tsx — new file created with 6 tests covering every case.
Local validation:
pnpm test FieldDateTime
pnpm lint
prek run --from-ref main --stage pre-commit
prek run --from-ref main --stage manual
all above 4 passed
Behavior impact
This does not change successful cleanup behavior.
This fix closes the issue #66492
Was generative AI tooling used to co-author this PR?
Yes — Claude Sonnet 4.6
Generated-by: Claude Sonnet 4.6 following the guidelines