Iterate file objects directly instead of calling readlines()

dev/airflow_perf/sql_queries.py

@@ -145,7 +145,7 @@ def make_report() -> list[Query]:
     """
     queries = []
     with open(LOG_FILE, "r+") as f:
-        raw_queries = [line for line in f.readlines() if is_query(line)]
+        raw_queries = [line for line in f if is_query(line)]
 
     for query in raw_queries:
         time, info, stack, sql = query.replace("@SQLALCHEMY ", "").split("|$")

dev/breeze/src/airflow_breeze/global_constants.py

@@ -670,7 +670,7 @@ def get_task_sdk_version():
 def get_airflow_extras():
     airflow_dockerfile = AIRFLOW_ROOT_PATH / "Dockerfile"
     with open(airflow_dockerfile) as dockerfile:
-        for line_raw in dockerfile.readlines():
+        for line_raw in dockerfile:
             if "ARG AIRFLOW_EXTRAS=" in line_raw:
                 line = line_raw.split("=")[1].strip()
                 return line.replace('"', "")

devel-common/src/sphinx_exts/redirects.py

@@ -41,7 +41,7 @@ def generate_redirects(app):
         return
 
     with open(redirect_file_path) as redirects:
-        for line in redirects.readlines():
+        for line in redirects:
             # Skip empty line
             if not line.strip():
                 continue

providers/google/tests/system/google/cloud/gcs/resources/transform_script.py

@@ -23,6 +23,6 @@
 
 print("Running script")
 with open(source) as src, open(destination, "w+") as dest:
-    lines = [line.upper() for line in src.readlines()]
+    lines = [line.upper() for line in src]
     print(lines)
     dest.writelines(lines)

scripts/ci/prek/newsfragments.py

@@ -67,7 +67,7 @@ def main(filenames: list[str]) -> int:
     failed = False
     for filename in filenames:
         with open(filename) as f:
-            lines = [line.strip() for line in f.readlines()]
+            lines = [line.strip() for line in f]
         errors = validate_newsfragment(filename, lines)
         for error in errors:
             print(error)