-
Notifications
You must be signed in to change notification settings - Fork 17k
Fix in-process Execution API secrets routing in client contexts #65587
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
henry3260
wants to merge
3
commits into
apache:main
Choose a base branch
from
henry3260:fix-infinite-waiting-get
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,59 @@ | ||
| # Licensed to the Apache Software Foundation (ASF) under one | ||
| # or more contributor license agreements. See the NOTICE file | ||
| # distributed with this work for additional information | ||
| # regarding copyright ownership. The ASF licenses this file | ||
| # to you under the Apache License, Version 2.0 (the | ||
| # "License"); you may not use this file except in compliance | ||
| # with the License. You may obtain a copy of the License at | ||
| # | ||
| # http://www.apache.org/licenses/LICENSE-2.0 | ||
| # | ||
| # Unless required by applicable law or agreed to in writing, | ||
| # software distributed under the License is distributed on an | ||
| # "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
| # KIND, either express or implied. See the License for the | ||
| # specific language governing permissions and limitations | ||
| # under the License. | ||
| from __future__ import annotations | ||
|
|
||
| import os | ||
| import sys | ||
| from collections.abc import Generator | ||
| from contextlib import contextmanager | ||
| from contextvars import ContextVar | ||
| from typing import Literal | ||
|
|
||
| __all__ = [ | ||
| "get_process_context", | ||
| "override_process_context", | ||
| "should_use_task_sdk_api_path", | ||
| ] | ||
|
|
||
| _PROCESS_CONTEXT_OVERRIDE: ContextVar[str | None] = ContextVar( | ||
| "_AIRFLOW_PROCESS_CONTEXT_OVERRIDE", | ||
| default=None, | ||
| ) | ||
|
|
||
|
|
||
| def get_process_context() -> str | None: | ||
| """Return the current process context, preferring request-scoped overrides.""" | ||
| return _PROCESS_CONTEXT_OVERRIDE.get() or os.environ.get("_AIRFLOW_PROCESS_CONTEXT") | ||
|
|
||
|
|
||
| @contextmanager | ||
| def override_process_context(context: Literal["server", "client"]) -> Generator[None, None, None]: | ||
| """Temporarily override the current process context for the active execution flow.""" | ||
| token = _PROCESS_CONTEXT_OVERRIDE.set(context) | ||
| try: | ||
| yield | ||
| finally: | ||
| _PROCESS_CONTEXT_OVERRIDE.reset(token) | ||
|
|
||
|
|
||
| def should_use_task_sdk_api_path() -> bool: | ||
| """Return True when execution-context helpers should route through Task SDK APIs.""" | ||
| if get_process_context() == "server": | ||
| return False | ||
|
|
||
| task_runner_module = sys.modules.get("airflow.sdk.execution_time.task_runner") | ||
| return bool(getattr(task_runner_module, "SUPERVISOR_COMMS", None)) | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It doesn't seem like a good place for these utilities. Shouldn't
models/*be something related to "Data Model" (or a Table in Metadata DB more specific).There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point on the directory structure. I'm also concerned that models/ isn't the right fit since these aren't DB models. Where would you suggest moving them? I previously thought about utils/, but the CI checks didn't allow that, and putting them in _shared might be overkill.