Skip to content

fix: task run exception never catch by Sentry#65161

Open
EpicFail4Ever wants to merge 6 commits into
apache:mainfrom
EpicFail4Ever:fix/sentry-error-catching
Open

fix: task run exception never catch by Sentry#65161
EpicFail4Ever wants to merge 6 commits into
apache:mainfrom
EpicFail4Ever:fix/sentry-error-catching

Conversation

@EpicFail4Ever
Copy link
Copy Markdown

@EpicFail4Ever EpicFail4Ever commented Apr 13, 2026

Hello, here is the PR linked with the issue #65136
closes: #65136

  • managing the error caching returned by the run itself.
  • Adding the call of sentry_sdk.capture_exception in the unit tests

Was generative AI tooling used to co-author this PR?
  • Yes (please specify the tool below)

  • Read the Pull Request Guidelines for more information. Note: commit author/co-author name and email in commits become permanently public when merged.
  • For fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
  • When adding dependency, check compliance with the ASF 3rd Party License Policy.
  • For significant user-facing changes create newsfragment: {pr_number}.significant.rst, in airflow-core/newsfragments. You can add this file in a follow-up commit after the PR is created so you know the PR number.

@eladkal eladkal changed the title Sentry error catching fix: task run exception never catch by Sentry Apr 13, 2026
@eladkal eladkal added this to the Airflow 3.2.1 milestone Apr 13, 2026
@eladkal eladkal added type:bug-fix Changelog: Bug Fixes backport-to-v3-2-test Mark PR with this label to backport to v3-2-test branch labels Apr 13, 2026
@Srabasti
Copy link
Copy Markdown
Contributor

Static checks are failing. Please run prek locally in your branch before committing to repo.

Copy link
Copy Markdown
Contributor

@Srabasti Srabasti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kindly replace single quotes with double quotes @EpicFail4Ever to fix - this is one of the places static checks are failing.

@EpicFail4Ever
Copy link
Copy Markdown
Author

Sorry for those CI Runs, I made a clean local dev setup and it should be fine now.

In Addition I made a change to update sentry_sdk deprecated methods according to

@EpicFail4Ever EpicFail4Ever requested a review from Srabasti April 14, 2026 12:58
@potiuk potiuk added the ready for maintainer review Set after triaging when all criteria pass. label Apr 22, 2026
@vatsrahul1001
Copy link
Copy Markdown
Contributor

@EpicFail4Ever can you resolve conflicts?

@EpicFail4Ever
Copy link
Copy Markdown
Author

Hello @vatsrahul1001.
It should be fine now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport-to-v3-2-test Mark PR with this label to backport to v3-2-test branch ready for maintainer review Set after triaging when all criteria pass. type:bug-fix Changelog: Bug Fixes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Task run exception never catch by Sentry

6 participants