-
Notifications
You must be signed in to change notification settings - Fork 17k
Fix GitDagBundle submodule clone not using SSH settings from connection #64879
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
shunsuke-sugita
wants to merge
26
commits into
apache:main
Choose a base branch
from
shunsuke-sugita:provider-git-fix-fetch-submodul
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+54
−6
Draft
Changes from 2 commits
Commits
Show all changes
26 commits
Select commit
Hold shift + click to select a range
4987c26
Fix Git bundle submodule fetch not using SSH settings from connection
shunsuke-sugita 46f66a4
Merge branch 'main' into provider-git-fix-fetch-submodul
shunsuke-sugita fd68b54
Rename cm to ssh_env_cm in _fetch_bare_repo and _fetch_submodules.
shunsuke-sugita 7e67b4c
Test GitDagBundle._fetch_submodules applies GIT_SSH_COMMAND via custo…
shunsuke-sugita ffb5e5a
Merge branch 'main' into provider-git-fix-fetch-submodul
shunsuke-sugita 799e084
Merge branch 'main' into provider-git-fix-fetch-submodul
shunsuke-sugita 21098f9
Merge branch 'main' into provider-git-fix-fetch-submodul
shunsuke-sugita 6346cb2
Use autospec for Git/Repo mocks in submodule fetch unit tests
shunsuke-sugita 2dcfd1d
Drop redundant mock_calls assertions in submodule fetch test
shunsuke-sugita fe31907
GitDagBundle: submodule custom_environment uses full hook.env
shunsuke-sugita 62d9068
Merge branch 'main' into provider-git-fix-fetch-submodul
shunsuke-sugita 6d27243
Rename submodule test for empty hook.env (custom_environment skip)
shunsuke-sugita 4f0d7fc
Update providers/git/tests/unit/git/bundles/test_git.py
shunsuke-sugita 9b6ca63
rm airflow
shunsuke-sugita 76fd8ca
Add missing blank line between submodule fetch tests
shunsuke-sugita 51f14ca
Fix submodule test call-order assertion (use mock_git.mock_calls, not…
shunsuke-sugita fa3f022
fix test
shunsuke-sugita 3ccbaf5
Merge branch 'main' into provider-git-fix-fetch-submodul
shunsuke-sugita b8084ed
Fix git bundle and Celery executor unit tests failing in provider CI
shunsuke-sugita 33def75
Fix git bundle and Celery executor unit tests for provider CI
shunsuke-sugita ce418f4
Merge branch 'main' into provider-git-fix-fetch-submodul
shunsuke-sugita 76cfd3a
Revert celery executor test changes (keep Git bundle PR scoped)
shunsuke-sugita 996de12
Merge branch 'main' into provider-git-fix-fetch-submodul
shunsuke-sugita cb599d8
Merge branch 'main' into provider-git-fix-fetch-submodul
shunsuke-sugita 6b1cc87
undo test_celery_executor fix
shunsuke-sugita 0b0c77a
Merge branch 'main' into provider-git-fix-fetch-submodul
shunsuke-sugita File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.