Skip to content

feat: adding the option to add bundle version parameter on dag run trigger endpoint#61550

Open
itayweb wants to merge 32 commits intoapache:mainfrom
itayweb:feat-bundle-version-support-dagrun
Open

feat: adding the option to add bundle version parameter on dag run trigger endpoint#61550
itayweb wants to merge 32 commits intoapache:mainfrom
itayweb:feat-bundle-version-support-dagrun

Conversation

@itayweb
Copy link
Copy Markdown
Contributor

@itayweb itayweb commented Feb 6, 2026

A new feature in the dag run REST API, adding the option to add bundle version parameter to trigger specific version.
Wasn't sure how can I add to this a unit test due to need a git repo/s3 bucket, let me know if needed


Was generative AI tooling used to co-author this PR?
  • Yes (please specify the tool below)

Generated-by: [Cursor] following the guidelines

@boring-cyborg boring-cyborg Bot added area:API Airflow's REST/HTTP API area:DAG-processing labels Feb 6, 2026
@itayweb itayweb force-pushed the feat-bundle-version-support-dagrun branch from 5b3753a to eea1f7d Compare February 7, 2026 14:58
@itayweb itayweb force-pushed the feat-bundle-version-support-dagrun branch from eea1f7d to a862cd3 Compare February 7, 2026 18:22
@itayweb itayweb requested a review from potiuk as a code owner February 7, 2026 18:22
@itayweb itayweb force-pushed the feat-bundle-version-support-dagrun branch from a862cd3 to d47dcd4 Compare February 8, 2026 12:33
@itayweb itayweb force-pushed the feat-bundle-version-support-dagrun branch 2 times, most recently from 4aad19c to a87673a Compare February 8, 2026 19:51
Copy link
Copy Markdown
Member

@pierrejeambrun pierrejeambrun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall this looks good to me.

Can you add unit tests to verify that behavior when we actually pass a 'bundle_version'.

I'd love a second look from versioning experts.

Comment thread airflow-core/src/airflow/serialization/definitions/dag.py Outdated
Copy link
Copy Markdown
Member

@jason810496 jason810496 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the improvement!

Please add the corresponding tests when you are convenient, thanks.

Comment thread airflow-core/src/airflow/api_fastapi/core_api/datamodels/dag_run.py
Copy link
Copy Markdown
Member

@pierrejeambrun pierrejeambrun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add the requested unit tests please so we can merge this.

Comment thread airflow-core/src/airflow/api_fastapi/core_api/routes/public/dag_run.py Outdated
@itayweb
Copy link
Copy Markdown
Contributor Author

itayweb commented Feb 18, 2026

I've added the unit test, let me know what do you think 😄 sorry for the delay

@itayweb itayweb force-pushed the feat-bundle-version-support-dagrun branch from 04ed537 to d128f41 Compare April 17, 2026 13:14
@potiuk
Copy link
Copy Markdown
Member

potiuk commented Apr 19, 2026

You need to rebase.

Copy link
Copy Markdown
Member

@pierrejeambrun pierrejeambrun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good feature. The core trickiness (TIs must be built from the resolved older dag, not the live one) is handled correctly and tested. Some concerns below, mostly around deduplication of the DagVersion lookup and the branching logic in _create_orm_dagrun.

CI need fixing.

Comment thread airflow-core/src/airflow/serialization/definitions/dag.py Outdated
Comment thread airflow-core/src/airflow/serialization/definitions/dag.py
Comment thread airflow-core/src/airflow/serialization/definitions/dag.py
Comment thread uv.lock
Comment thread airflow-core/src/airflow/models/dag_version.py
@potiuk potiuk marked this pull request as draft April 23, 2026 01:01
@potiuk
Copy link
Copy Markdown
Member

potiuk commented Apr 23, 2026

@itayweb Converting to draft — this PR doesn't yet meet our Pull Request quality criteria.

  • Merge conflicts: this branch has conflicts with main and cannot be merged as-is. Rebase: git fetch upstream main && git rebase upstream/main, resolve, force-push.
  • Failing CI: Special tests / Pendulum2 test: core / All-core:Pendulum2-Postgres:14:3.10:API...CLI, Special tests / Latest SQLAlchemy test: core / DB-core:LatestSQLAlchemy-Postgres:14:3.10:API...CLI, Special tests / Latest Boto test: core / All-core:LatestBoto-Postgres:14:3.10:API...CLI (+5 more). Please investigate and fix.
  • Unresolved review comments (8 threads (from maintainers)): please walk through each unresolved review thread. Even if a suggestion looks incorrect or irrelevant — and some of them will be, especially any comments left by automated reviewers like GitHub Copilot — it is still the author's responsibility to respond: apply the fix, reply in-thread with a brief explanation of why the suggestion does not apply, or resolve the thread if the feedback is no longer relevant. Once you believe a thread is resolved — whether by pushing a fix or by explaining why the suggestion doesn't apply — please mark it as resolved yourself by clicking the 'Resolve conversation' button at the bottom of each thread. Reviewers don't auto-close their own threads, so an addressed-but-unresolved thread reads as 'still waiting on the author' and keeps the PR from moving forward.

See the linked criteria for how to fix each item, then mark the PR "Ready for review". This is not a rejection — just an invitation to bring the PR up to standard. No rush.


Note: This comment was drafted by an AI-assisted triage tool and may contain mistakes. Once you have addressed the points above, an Apache Airflow maintainer — a real person — will take the next look at your PR. We use this two-stage triage process so that our maintainers' limited time is spent where it matters most: the conversation with you.

@itayweb itayweb marked this pull request as ready for review May 2, 2026 09:55
@itayweb itayweb marked this pull request as draft May 2, 2026 15:34
@itayweb itayweb marked this pull request as ready for review May 3, 2026 20:56
@potiuk potiuk added the ready for maintainer review Set after triaging when all criteria pass. label May 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:API Airflow's REST/HTTP API area:DAG-processing ready for maintainer review Set after triaging when all criteria pass.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support bundle version param in trigger dag run endpoint

8 participants