feat: adding the option to add bundle version parameter on dag run trigger endpoint#61550
feat: adding the option to add bundle version parameter on dag run trigger endpoint#61550itayweb wants to merge 32 commits intoapache:mainfrom
Conversation
5b3753a to
eea1f7d
Compare
eea1f7d to
a862cd3
Compare
a862cd3 to
d47dcd4
Compare
4aad19c to
a87673a
Compare
jason810496
left a comment
There was a problem hiding this comment.
Thanks for the improvement!
Please add the corresponding tests when you are convenient, thanks.
pierrejeambrun
left a comment
There was a problem hiding this comment.
Can you add the requested unit tests please so we can merge this.
|
I've added the unit test, let me know what do you think 😄 sorry for the delay |
…ion api versioning, and also getting latest version of dag with bundle version
04ed537 to
d128f41
Compare
|
You need to rebase. |
There was a problem hiding this comment.
Good feature. The core trickiness (TIs must be built from the resolved older dag, not the live one) is handled correctly and tested. Some concerns below, mostly around deduplication of the DagVersion lookup and the branching logic in _create_orm_dagrun.
CI need fixing.
|
@itayweb Converting to draft — this PR doesn't yet meet our Pull Request quality criteria.
See the linked criteria for how to fix each item, then mark the PR "Ready for review". This is not a rejection — just an invitation to bring the PR up to standard. No rush. Note: This comment was drafted by an AI-assisted triage tool and may contain mistakes. Once you have addressed the points above, an Apache Airflow maintainer — a real person — will take the next look at your PR. We use this two-stage triage process so that our maintainers' limited time is spent where it matters most: the conversation with you. |
…on-explicit triggers
A new feature in the dag run REST API, adding the option to add bundle version parameter to trigger specific version.
Wasn't sure how can I add to this a unit test due to need a git repo/s3 bucket, let me know if needed
Was generative AI tooling used to co-author this PR?
Generated-by: [Cursor] following the guidelines