Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate Amazon provider package #46590

Merged
merged 1 commit into from
Feb 9, 2025
Merged

Migrate Amazon provider package #46590

merged 1 commit into from
Feb 9, 2025

Conversation

potiuk
Copy link
Member

@potiuk potiuk commented Feb 8, 2025

Fixes: #46045


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@potiuk
Copy link
Member Author

potiuk commented Feb 8, 2025

cc: @o-nikolas -> could not add fixup in your PR so created a new one (but you are author still) :)

Copy link
Contributor

@jscheffl jscheffl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@potiuk potiuk force-pushed the migrante_ampp branch 3 times, most recently from ddb0879 to 3116fc7 Compare February 9, 2025 00:03
Copy link
Contributor

@o-nikolas o-nikolas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking this one across the line! I was hoping to get it done on Friday, but a looot of things broke so it was taking a while. Amazon is used quite a bit in a lot of core tests as well which is interesting.

The build looks green, but please do have a look at my commits in #46498 to ensure they're correct, otherwise lgtm 👍

@potiuk
Copy link
Member Author

potiuk commented Feb 9, 2025

Yeah. I took it from your PR initially and added some fixes :)

@potiuk potiuk merged commit fdb934f into apache:main Feb 9, 2025
91 checks passed
@potiuk potiuk deleted the migrante_ampp branch February 9, 2025 08:17
vargacypher pushed a commit to vargacypher/airflow that referenced this pull request Feb 9, 2025
@o-nikolas
Copy link
Contributor

Yeah. I took it from your PR initially and added some fixes :)

Sad that it merged as your commit, because I spent a lot of time on it 😅, but thanks again for taking it across the line!

@ferruzzi
Copy link
Contributor

🎉

@potiuk
Copy link
Member Author

potiuk commented Feb 10, 2025

Sad that it merged as your commit, because I spent a lot of time on it 😅, but thanks again for taking it across the line!

Well. Not really. I am very careful about those of not to remove the original author

We are both co-authors of that merged commit:

Screenshot 2025-02-11 at 00 00 48

ambika-garg pushed a commit to ambika-garg/airflow that referenced this pull request Feb 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Convert remaining providers to the new structure
4 participants