-
Notifications
You must be signed in to change notification settings - Fork 14.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate Amazon provider package #46590
Conversation
cc: @o-nikolas -> could not add fixup in your PR so created a new one (but you are author still) :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
ddb0879
to
3116fc7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for taking this one across the line! I was hoping to get it done on Friday, but a looot of things broke so it was taking a while. Amazon is used quite a bit in a lot of core tests as well which is interesting.
The build looks green, but please do have a look at my commits in #46498 to ensure they're correct, otherwise lgtm 👍
Yeah. I took it from your PR initially and added some fixes :) |
Fixes: apache#46045 Co-authored-by: Niko Oliveira <[email protected]>
Sad that it merged as your commit, because I spent a lot of time on it 😅, but thanks again for taking it across the line! |
🎉 |
Fixes: apache#46045 Co-authored-by: Niko Oliveira <[email protected]>
Fixes: #46045
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rst
or{issue_number}.significant.rst
, in newsfragments.