Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move opensearch provider to new structure #46210

Merged

Conversation

josix
Copy link
Contributor

@josix josix commented Jan 28, 2025

related: #46045

  • fix unit tests

^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@potiuk
Copy link
Member

potiuk commented Jan 30, 2025

This one will have to be solved differentlly:

  Using Python 3.9.21 environment at: /usr/local
  Uninstalled 4 packages in 400ms
   - aiobotocore==2.19.0
   - opensearch-py==2.8.0
   - s3fs==2024.12.0
   - yandexcloud==0.328.0
  + uv pip install --system --upgrade boto3 botocore 'oss2>=2.14.0' 'cryptography<43.0.0' 'requests!=2.32.*,<3.0.0,>=2.24.0'
  Using Python 3.9.21 environment at: /usr/local
  Resolved 19 packages in 469ms
  Prepared 3 packages in 476ms
  Uninstalled 3 packages in 928ms
  Installed 3 packages in 143ms
   - boto3==1.36.3
   + boto3==1.36.9
   - botocore==1.36.3
   + botocore==1.36.9
   - requests==2.32.3
   + requests==2.31.0
  + set +xe 
  apache-airflow-providers-opensearch 1.6.0 requires opensearch-py, which is not installed.

When installing latest botocore, opensearch-py gets uninstalled and opensearch provider needs it. Once we split it out, right now UV will (correctly) complain that the apache-airflow-providers-opensearch cannot be installed. I will have to think how to solve it (don't know yet) :) .

That's an interesting find.

@potiuk
Copy link
Member

potiuk commented Jan 30, 2025

This one should be rebased after #46289 -> the latest boto tests removed opensearch, but recent apache.beam releases already removed requests limitation that blocked it.

@josix josix force-pushed the refactor/move-opensearch-provider-to-new-structure branch from 9ea075f to ec307f9 Compare January 30, 2025 17:53
@josix
Copy link
Contributor Author

josix commented Jan 30, 2025

Thank you so much for helping to resolve it 🙇🏻‍♂️

@jscheffl jscheffl merged commit 6d8457c into apache:main Jan 30, 2025
91 checks passed
Prab-27 pushed a commit to Prab-27/airflow that referenced this pull request Jan 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants