-
Notifications
You must be signed in to change notification settings - Fork 14.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AIP-82 Handle trigger serialization #45562
base: main
Are you sure you want to change the base?
Conversation
fa9f975
to
5f2a621
Compare
5f2a621
to
d7d1e3b
Compare
I addressed your comments but I also added something new. It was actually a suggestion from @dstandish that I think is a great idea! I introduced the concept of Instead of having:
Now it is:
|
f64e72d
to
29b9834
Compare
I'll take another look today or tomorrow. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks much better thanks, but a few changes I'd like you to make please.
3859d7a
to
021c863
Compare
Co-authored-by: Ash Berlin-Taylor <[email protected]>
Other questions/concerns? :) |
@ashb Are you okay with these changes? I'll make the changes related to the discussion we had on Slack (creating the interface |
All good, thanks @vincbeck |
Handle serialization of triggers in DAGs as part of AIP-82. With AIP-82 (External event driven scheduling in Airflow) you can define DAGs as below:
Triggers can be instantiated as part of a DAG. As such, we need to serialize them.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rst
or{issue_number}.significant.rst
, in newsfragments.