Re-add conditional prod image build #45320
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
potiuk
changed the title
potiuk
force-pushed
the
re-add-conditional-prod-image-build
branch
from
1f59608 to
123078d
Compare
|
Realized that after #45319 |
Prod image build sometimes (quite often) is not needed. When removing `pull_request_target` in apache#45266 `wait-for=prod-images` had the condition that prevented it from running (and the `build-prod-images` step depended on it) - but this condition is gone now. Instead of preventing the whole composite workflow from running, we are adding it to "build-prod-packages" so that the whole workflow can complete as prerequisite to "finalize-tests" which should be executed regardless from `prod-image-build` being executed.
potiuk
force-pushed
the
re-add-conditional-prod-image-build
branch
from
123078d to
83545c5
Compare
hussein-awala
approved these changes
Jan 1, 2025
gopidesupavan
approved these changes
Jan 1, 2025
LefterisXefteris
pushed a commit
to LefterisXefteris/airflow
that referenced
this pull request
Jan 5, 2025
Prod image build sometimes (quite often) is not needed. When removing `pull_request_target` in apache#45266 `wait-for=prod-images` had the condition that prevented it from running (and the `build-prod-images` step depended on it) - but this condition is gone now. Instead of preventing the whole composite workflow from running, we are adding it to "build-prod-packages" so that the whole workflow can complete as prerequisite to "finalize-tests" which should be executed regardless from `prod-image-build` being executed.
agupta01
pushed a commit
to agupta01/airflow
that referenced
this pull request
Jan 6, 2025
Prod image build sometimes (quite often) is not needed. When removing `pull_request_target` in apache#45266 `wait-for=prod-images` had the condition that prevented it from running (and the `build-prod-images` step depended on it) - but this condition is gone now. Instead of preventing the whole composite workflow from running, we are adding it to "build-prod-packages" so that the whole workflow can complete as prerequisite to "finalize-tests" which should be executed regardless from `prod-image-build` being executed.
HariGS-DB
pushed a commit
to HariGS-DB/airflow
that referenced
this pull request
Jan 16, 2025
Prod image build sometimes (quite often) is not needed. When removing `pull_request_target` in apache#45266 `wait-for=prod-images` had the condition that prevented it from running (and the `build-prod-images` step depended on it) - but this condition is gone now. Instead of preventing the whole composite workflow from running, we are adding it to "build-prod-packages" so that the whole workflow can complete as prerequisite to "finalize-tests" which should be executed regardless from `prod-image-build` being executed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prod image build sometimes (quite often) is not needed. When removing
pull_request_targetin #45266wait-for=prod-imageshad the condition that prevented it from running (and thebuild-prod-imagesstep depended on it) - but this condition is gone now.Instead of preventing the whole composite workflow from running, we are adding it to "build-prod-packages" so that the whole workflow can complete as prerequisite to "finalize-tests" which should be executed regardless from
prod-image-buildbeing executed.^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.